WX-1611 Make deploy process 'compatible" with quotes 🎉 (#7423)

Author: aednichols

.github/library/get_jira_id/action.yml

@@ -0,0 +1,23 @@
+name: 'Get Jira ID'
+outputs:
+  jira-id:
+    value: ${{ steps.get-id.outputs.jira-id }}
+
+runs:
+  using: "composite" # <-- this allows these steps to be used by other workflows.
+  steps:
+    - name: "Get ID or fail"
+      id: get-id
+      uses: actions/github-script@v7
+      with:
+        script: |
+          const title = context.payload.pull_request.title;
+          const regex = /[A-Z][A-Z]+-\d+/;
+          const match = title.match(regex)
+          
+          if (!match) {
+            core.setFailed("PR title must contain a Jira tag");
+          } else {
+            console.log("Set output " + match[0]);
+            core.setOutput("jira-id", match[0]);
+          }

.github/workflows/chart_update_on_merge.yml

@@ -11,12 +11,8 @@ jobs:
     if: github.event.pull_request.merged == true
     runs-on: ubuntu-latest
     steps:
-    - name: Fetch Jira ID from the commit message
-      id: fetch-jira-id
-      run: |
-        JIRA_ID=$(echo '${{ github.event.pull_request.title }}' | grep -Eo '[A-Z][A-Z]+-[0-9]+' | xargs echo -n | tr '[:space:]' ',')
-        [[ -z "$JIRA_ID" ]] && { echo "No Jira ID found in $1" ; exit 1; }
-        echo "JIRA_ID=$JIRA_ID" >> $GITHUB_OUTPUT
+    - id: get-jira-id
+      uses: ./.github/library/get_jira_id
     - name: Clone Cromwell
       uses: actions/checkout@v2
       with:
@@ -88,7 +84,7 @@ jobs:
         git diff
         git config --global user.name "broadbot"
         git config --global user.email "broadbot@broadinstitute.org"
-        git commit -am "${{ steps.fetch-jira-id.outputs.JIRA_ID }}: Auto update to Cromwell $CROMWELL_VERSION"
+        git commit -am "${{ steps.get-jira-id.outputs.jira-id }}: Auto update to Cromwell $CROMWELL_VERSION"
         git push https://broadbot:$BROADBOT_GITHUB_TOKEN@github.com/broadinstitute/cromwhelm.git main
         cd -
 
@@ -120,7 +116,7 @@ jobs:
         GH_TOKEN: ${{ secrets.BROADBOT_GITHUB_TOKEN }}
       run: |
         set -e
-        JIRA_ID=${{ steps.fetch-jira-id.outputs.JIRA_ID }}
+        JIRA_ID=${{ steps.get-jira-id.outputs.jira-id }}
         if [[ $JIRA_ID == "missing" ]]; then
           echo "JIRA_ID missing, PR to terra-helmfile will not be created"
           exit 0;

.github/workflows/validate_pr_name.yml

@@ -10,14 +10,7 @@ jobs:
   validate_pr_name:
     runs-on: ubuntu-latest
     steps:
-      - name: Validate PR title
-        id: validate
-        uses: actions/github-script@v3
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const title = context.payload.pull_request.title;
-            const regex = /[A-Z][A-Z]+-\d+/;
-            if (!regex.test(title)) {
-              core.setFailed("PR title must contain a Jira tag");
-            }
+      - uses: actions/checkout@v4
+      - id: get-jira-id
+        uses: ./.github/library/get_jira_id
+      - run: echo Jira ID is ${{ steps.get-jira-id.outputs.jira-id }}