Skip to content

Different Doctrine types name format #3

@paoloconi96

Description

@paoloconi96

Hi @BenMorel,
thanks a lot for your work and this library.

During my last development I noticed that the names you used for Doctrine types is different from the Doctrine DBAL standard naming.
In the Doctrine official library the types are named this way:

[...]
    public const DATE_IMMUTABLE       = 'date_immutable';
    public const DATEINTERVAL         = 'dateinterval';
    public const DATETIME_MUTABLE     = 'datetime';
    public const DATETIME_IMMUTABLE   = 'datetime_immutable';
    public const DATETIMETZ_MUTABLE   = 'datetimetz';
    public const DATETIMETZ_IMMUTABLE = 'datetimetz_immutable';
[...]

while in your library you use the camelCase notation:

[...]
final class LocalDateTimeType extends Type
{
    public function getName(): string
    {
        return 'LocalDateTime';
    }
[...]

Can I ask you why? Would you consider to change this if I open a pull request for this change?

Hope to hear from you soon

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions