-
-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
Hi @BenMorel,
thanks a lot for your work and this library.
During my last development I noticed that the names you used for Doctrine types is different from the Doctrine DBAL standard naming.
In the Doctrine official library the types are named this way:
[...]
public const DATE_IMMUTABLE = 'date_immutable';
public const DATEINTERVAL = 'dateinterval';
public const DATETIME_MUTABLE = 'datetime';
public const DATETIME_IMMUTABLE = 'datetime_immutable';
public const DATETIMETZ_MUTABLE = 'datetimetz';
public const DATETIMETZ_IMMUTABLE = 'datetimetz_immutable';
[...]
while in your library you use the camelCase notation:
[...]
final class LocalDateTimeType extends Type
{
public function getName(): string
{
return 'LocalDateTime';
}
[...]
Can I ask you why? Would you consider to change this if I open a pull request for this change?
Hope to hear from you soon
JanTvrdik
Metadata
Metadata
Assignees
Labels
No labels