Failed but succesfull HTTP calls hard to debug

[kvij]

When the HTTP call itself succeeds there is no error given while the action does fail.
This happens when there is a non 2xx status code like when an invalid API KEY is provided or there is a subscription issue.
Normally this can be checked in the response but this library handles responses without returning them.

So even if the status code indicates a failure the response of the library is a normal result without an error. The result struct will contain the default zero values of the type. The only way to debug this is by actually using a debugger to inspect the values.

I think that the status code should be checked for non 2xx status codes and an error with the status code and perhaps even the body should be returned.

[chilledornaments]

There's a PR to do a big rewrite of the project and it looks like it includes exactly what you're describing.

@briandowns I really like the direction of the changes in the version 1 rewrite PR. Looks like it's been a bit since there's been activity on that branch. If there's anything I can do to help, I'd love to lend a hand 🙂

[zalegrala]

I'd also be willing to lend a couple hours on the weekend if that helps move us forward.