Skip to content

Commit 260c46e

Browse files
committed
Check various errors in getting CPAN version
1 parent 0dd5749 commit 260c46e

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

script/release

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -566,13 +566,22 @@ unless( $opts{V} // $release->config->skip_cpan_version_check ) {
566566
$release->dist;
567567
$release->_print("Module name is <". $release->module_name . ">\n");
568568

569-
my $cpan = $release->cpan_version // '<undef>';
570-
my $dist = eval { $release->dist_version } // '<error?>';
569+
my $cpan_v_default = '<undef>';
570+
571+
my $cpan = $release->cpan_version // $cpan_v_default;
572+
my $dist = eval { $release->dist_version };
573+
my $dist_v_error = $@;
571574

572575
$release->_print("CPAN Version: $cpan\n");
573576
$release->_print("Dist Version: $dist\n");
574577

575-
if( version->parse($cpan) >= version->parse($dist) ) {
578+
if( length $dist_v_error ) {
579+
$release->_die( "Could not get dist version: $dist_v_error\n" );
580+
}
581+
elsif( $cpan eq '<undef>' ) {
582+
$release->_die( "Could not get CPAN version.\nSkip this CPAN version check with -V if you are sure you want to continue\n" );
583+
}
584+
elsif( version->parse($cpan) >= version->parse($dist) ) {
576585
$release->_die( "Local version <$dist> is not greater than current version <$cpan>\n" );
577586
}
578587
}

0 commit comments

Comments
 (0)