Refactor event subscriptions

Author: brexis

src/Events/CompletedEvent.php

@@ -2,7 +2,10 @@
 
 namespace Brexis\LaravelWorkflow\Events;
 
+/**
+ * @author Peter Sweets <p.sweets@developers.nl>
+ */
 class CompletedEvent extends BaseEvent
 {
-
-}
+  //
+}

src/Events/EnterEvent.php

@@ -7,4 +7,5 @@
  */
 class EnterEvent extends BaseEvent
 {
+    //
 }

src/Events/EnteredEvent.php

@@ -7,4 +7,5 @@
  */
 class EnteredEvent extends BaseEvent
 {
+    //
 }

src/Events/LeaveEvent.php

@@ -7,4 +7,5 @@
  */
 class LeaveEvent extends BaseEvent
 {
+    //
 }

src/Events/TransitionEvent.php

@@ -7,4 +7,5 @@
  */
 class TransitionEvent extends BaseEvent
 {
+    //
 }

src/Events/WorkflowSubscriber.php

@@ -13,59 +13,79 @@ class WorkflowSubscriber implements EventSubscriberInterface
 {
     public function guardEvent(SymfonyGuardEvent $event)
     {
+        $workflowName   = $event->getWorkflowName();
+        $transitionName = $event->getTransition()->getName();
+
         event(new GuardEvent($event));
         event('workflow.guard', $event);
-        event('workflow.' . $event->getWorkflowName() . '.guard', $event);
-        event('workflow.' . $event->getWorkflowName() . '.guard.' . $event->getTransition()->getName(), $event);
+        event(sprintf('workflow.%s.guard', $workflowName), $event);
+        event(sprintf('workflow.%s.guard.%s', $workflowName, $transitionName), $event);
     }
 
     public function leaveEvent(Event $event)
     {
+        $places       = $event->getTransition()->getFroms();
+        $workflowName = $event->getWorkflowName();
+
         event(new LeaveEvent($event));
         event('workflow.leave', $event);
-        event('workflow.' . $event->getWorkflowName() . '.leave', $event);
-        foreach ($event->getTransition()->getFroms() as $marking) {
-            event('workflow.' . $event->getWorkflowName() . '.leave.' . $marking, $event);
+        event(sprintf('workflow.%s.leave', $workflowName), $event);
+
+        foreach ($places as $place) {
+            event(sprintf('workflow.%s.leave.%s', $workflowName, $place), $event);
         }
     }
 
     public function transitionEvent(Event $event)
     {
+        $workflowName   = $event->getWorkflowName();
+        $transitionName = $event->getTransition()->getName();
+
         event(new TransitionEvent($event));
         event('workflow.transition', $event);
-        event('workflow.' . $event->getWorkflowName() . '.transition', $event);
-        event('workflow.' . $event->getWorkflowName() . '.transition.' . $event->getTransition()->getName(), $event);
+        event(sprintf('workflow.%s.transition', $workflowName), $event);
+        event(sprintf('workflow.%s.transition.%s', $workflowName, $transitionName), $event);
     }
 
     public function enterEvent(Event $event)
     {
+        $places       = $event->getTransition()->getTos();
+        $workflowName = $event->getWorkflowName();
+
         event(new EnterEvent($event));
         event('workflow.enter', $event);
-        event('workflow.' . $event->getWorkflowName() . '.enter', $event);
-        foreach ($event->getTransition()->getTos() as $marking) {
-            event('workflow.' . $event->getWorkflowName() . '.enter.' . $marking, $event);
+        event(sprintf('workflow.%s.enter', $workflowName), $event);
+
+        foreach ($places as $place) {
+            event(sprintf('workflow.%s.enter.%s', $workflowName, $place), $event);
         }
     }
 
     public function enteredEvent(Event $event)
     {
+        $places       = $event->getTransition()->getTos();
+        $workflowName = $event->getWorkflowName();
+
         event(new EnteredEvent($event));
         event('workflow.entered', $event);
-        event('workflow.' . $event->getWorkflowName() . '.entered', $event);
-        foreach ($event->getTransition()->getTos() as $marking) {
-            event('workflow.' . $event->getWorkflowName() . '.entered.' . $marking, $event);
+        event(sprintf('workflow.%s.entered', $workflowName), $event);
+
+        foreach ($places as $place) {
+            event(sprintf('workflow.%s.entered.%s', $workflowName, $place), $event);
         }
     }
 
     public function completedEvent(Event $event)
     {
+        $workflowName   = $event->getWorkflowName();
+        $transitionName = $event->getTransition()->getName();
+
         event(new CompletedEvent($event));
         event('workflow.completed', $event);
-        event('workflow.' . $event->getWorkflowName() . '.completed', $event);
-        event('workflow.' . $event->getWorkflowName() . '.completed.' . $event->getTransition()->getName(), $event);
+        event(sprintf('workflow.%s.completed', $workflowName), $event);
+        event(sprintf('workflow.%s.completed.%s', $workflowName, $transitionName), $event);
     }
 
-
     public static function getSubscribedEvents()
     {
         return [