Fixed some typos and styling issues

Author: Willem Oostendorp

src/WorkflowRegistry.php

@@ -11,6 +11,7 @@
 use Symfony\Component\Workflow\MarkingStore\SingleStateMarkingStore;
 use Symfony\Component\Workflow\Registry;
 use Symfony\Component\Workflow\StateMachine;
+use Symfony\Component\Workflow\SupportStrategy\SupportStrategyInterface;
 use Symfony\Component\Workflow\Transition;
 use Symfony\Component\Workflow\Workflow;
 use Symfony\Component\Workflow\SupportStrategy\ClassInstanceSupportStrategy;
@@ -21,7 +22,7 @@
 class WorkflowRegistry
 {
     /**
-     * @var Symfony\Component\Workflow\Registry
+     * @var Registry
      */
     private $registry;
 
@@ -35,13 +36,19 @@ class WorkflowRegistry
      */
     private $dispatcher;
 
+    /**
+     * WorkflowRegistry constructor
+     *
+     * @param  array $config
+     * @throws \ReflectionException
+     */
     public function __construct(array $config)
     {
-        $this->registry     = new Registry();
-        $this->config       = $config;
-        $this->dispatcher   = new EventDispatcher();
+        $this->registry   = new Registry();
+        $this->config     = $config;
+        $this->dispatcher = new EventDispatcher();
 
-        $subscriber         = new WorkflowSubscriber();
+        $subscriber       = new WorkflowSubscriber();
         $this->dispatcher->addSubscriber($subscriber);
 
         foreach ($this->config as $name => $workflowData) {
@@ -55,9 +62,9 @@ public function __construct(array $config)
                 $builder->addTransition(new Transition($transitionName, $transition['from'], $transition['to']));
             }
 
-            $definition     = $builder->build();
-            $markingStore   = $this->getMakingStoreInstance($workflowData);
-            $workflow       = $this->getWorkflowInstance($name, $workflowData, $definition, $markingStore);
+            $definition   = $builder->build();
+            $markingStore = $this->getMarkingStoreInstance($workflowData);
+            $workflow     = $this->getWorkflowInstance($name, $workflowData, $definition, $markingStore);
 
             foreach ($workflowData['supports'] as $supportedClass) {
                 $this->add($workflow, $supportedClass);
@@ -66,7 +73,8 @@ public function __construct(array $config)
     }
 
     /**
-     * Return the $subject workflo
+     * Return the $subject workflow
+     *
      * @param  object $subject
      * @param  string $workflowName
      * @return Workflow
@@ -78,31 +86,36 @@ public function get($subject, $workflowName = null)
 
     /**
      * Add a workflow to the subject
-     * @param Workflow $workflow
-     * @param Symfony\Component\Workflow\SupportStrategy\SupportStrategyInterface $supportStrategy
+     *
+     * @param Workflow                 $workflow
+     * @param SupportStrategyInterface $supportStrategy
      */
-    public function add(Workflow $workflow, $supportStrategy)
+    public function add(Workflow $workflow, SupportStrategyInterface $supportStrategy)
     {
-        return $this->registry->add($workflow, new ClassInstanceSupportStrategy($supportStrategy));
+        $this->registry->add($workflow, new ClassInstanceSupportStrategy($supportStrategy));
     }
 
     /**
      * Return the workflow instance
      *
-     * @param  String                                                        $name
-     * @param  array                                                         $workflowData
-     * @param  Symfony\Component\Workflow\Definition                         $definition
-     * @param  Symfony\Component\Workflow\MarkingStore\MarkingStoreInterface $makingStore
-     * @return Symfony\Component\Workflow\Workflow
+     * @param  String                $name
+     * @param  array                 $workflowData
+     * @param  Definition            $definition
+     * @param  MarkingStoreInterface $markingStore
+     * @return Workflow
      */
-    private function getWorkflowInstance($name, $workflowData, Definition $definition, MarkingStoreInterface $markingStore)
-    {
+    private function getWorkflowInstance(
+        $name,
+        array $workflowData,
+        Definition $definition,
+        MarkingStoreInterface $markingStore
+    ) {
         $type  = isset($workflowData['type']) ? $workflowData['type'] : 'workflow';
         $className = Workflow::class;
 
         if ($type === 'state_machine') {
             $className = StateMachine::class;
-        } else if (isset($workflowData['class'])) {
+        } elseif (isset($workflowData['class'])) {
             $className = $workflowData['class'];
         }
 
@@ -112,24 +125,21 @@ private function getWorkflowInstance($name, $workflowData, Definition $definitio
     /**
      * Return the making store instance
      *
-     * @param  array $makingStoreData
-     * @return Symfony\Component\Workflow\MarkingStore\MarkingStoreInterface
+     * @param  array $workflowData
+     * @return MarkingStoreInterface
+     * @throws \ReflectionException
      */
-    private function getMakingStoreInstance($workflowData)
+    private function getMarkingStoreInstance(array $workflowData)
     {
-        $makingStoreData    = isset($workflowData['marking_store']) ? $workflowData['marking_store'] : [];
-        $type               = isset($makingStoreData['type']) ? $makingStoreData['type'] : 'single_state';
-        $className          = SingleStateMarkingStore::class;
-        $arguments          = [];
+        $markingStoreData = isset($workflowData['marking_store']) ? $workflowData['marking_store'] : [];
+        $type             = isset($markingStoreData['type']) ? $markingStoreData['type'] : 'single_state';
+        $className        = SingleStateMarkingStore::class;
+        $arguments        = isset($markingStoreData['arguments']) ? $markingStoreData['arguments'] : [];
 
         if ($type === 'multiple_state') {
             $className = MultipleStateMarkingStore::class;
-        } else if (isset($workflowData['class'])) {
-            $className = $workflowData['class'];
-        }
-
-        if (isset($makingStoreData['arguments'])) {
-            $arguments = $makingStoreData['arguments'];
+        } elseif (isset($markingStoreData['class'])) {
+            $className = $markingStoreData['class'];
         }
 
         $class = new \ReflectionClass($className);