test dot notation

Author: brenoroosevelt

src/DotNotation.php

@@ -52,24 +52,16 @@ function get_path(array $haystack, string $path, $default = null, string $separa
  */
 function unset_path(array &$haystack, string $path, string $separator = '.')
 {
-    $key = trim($path, $separator);
-    $keys = explode($separator, $key);
-    if (empty($keys)) {
-        return;
-    }
-
-    $target = &$haystack;
-    foreach ($keys as $innerKey) {
-        if (! is_array($target)) {
-            break;
-        }
-
-        if (array_key_exists($innerKey, $target)) {
-            $target = &$target[$innerKey];
+    $keys = explode($separator, $path);
+    $temp =& $haystack;
+    while (count($keys) > 1) {
+        $key = array_shift($keys);
+        if (array_key_exists($key, $temp) and is_array($temp[$key])) {
+            $temp =& $temp[$key];
         }
     }
 
-    unset($target);
+    unset($temp[array_shift($keys)]);
 }
 
 /**

tests/DotNotationTest.php

@@ -5,7 +5,9 @@
 
 use PHPUnit\Framework\TestCase;
 use function BrenoRoosevelt\get_path;
+use function BrenoRoosevelt\has_path;
 use function BrenoRoosevelt\set_path;
+use function BrenoRoosevelt\unset_path;
 
 class DotNotationTest extends TestCase
 {
@@ -126,4 +128,153 @@ public function testGetPath(array $items, string $path, $default, $expected): vo
         $actual = get_path($items, $path, $default);
         $this->assertEquals($expected, $actual);
     }
+
+    public function hasPathProvider(): array
+    {
+        $abcdNull = ['a' => ['b' => ['c' => ['d' => null]]]];
+        return [
+            'case_1' => [
+                [],
+                '',
+                false
+            ],
+            'case_2' => [
+                [1, 2, 3],
+                '0',
+                true
+            ],
+            'case_3' => [
+                [1, 2, 3],
+                '2',
+                true
+            ],
+            'case_4' => [
+                [[[[1, 2, 3]]]],
+                '0.0.0.2',
+                true
+            ],
+            'case_5' => [
+                [[[[1, 2, 3]]]],
+                '0.0.0.3',
+                false
+            ],
+            'case_6' => [
+                [[[[1, 2, 3]]]],
+                '0.0',
+                true
+            ],
+            'case_7' => [
+                [[[0, 1 => [1, 2], [1, 2, 3]]]],
+                '0.0.1',
+                true
+            ],
+            'case_8' => [
+                $abcdNull,
+                '0',
+                false
+            ],
+            'case_9' => [
+                $abcdNull,
+                'a',
+                true
+            ],
+            'case_10' => [
+                $abcdNull,
+                'a.b',
+                true
+            ],
+            'case_11' => [
+                $abcdNull,
+                'a.b.c',
+                true
+            ],
+            'case_12' => [
+                $abcdNull,
+                'a.b.c.d',
+                true
+            ],
+            'case_13' => [
+                ['a' => null],
+                'a',
+                true
+            ],
+            'case_14' => [
+                ['a' => ['b' => null]],
+                'a.b',
+                true
+            ],
+            'case_15' => [
+                ['a' => ['b' => false]],
+                'a.b',
+                true
+            ],
+            'case_16' => [
+                ['a' => ['b' => 0]],
+                'a.b',
+                true
+            ],
+        ];
+    }
+
+    /**
+     * @param array $items
+     * @param string $path
+     * @param $expected
+     * @return void
+     * @dataProvider hasPathProvider
+     */
+    public function testHasPath(array $items, string $path, $expected)
+    {
+        $actual = has_path($items, $path);
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function unsetPathProvider(): array
+    {
+        return [
+            'case_1' => [
+                [],
+                '',
+                []
+            ],
+            'case_2' => [
+                [1, 2, 3],
+                '3',
+                [1, 2, 3]
+            ],
+            'case_3' => [
+                [1, 2, 3],
+                '2',
+                [1, 2]
+            ],
+            'case_4' => [
+                [1, 2, 3],
+                '0',
+                [1 => 2, 2 => 3]
+            ],
+            'case_5' => [
+                [[[[1, 2, 3]]]],
+                '0.0.0.1',
+                [[[[1, 2 => 3]]]],
+            ],
+            'case_6' => [
+                [['x' => [[1, 2 => 3]]], 9],
+                '0.x',
+                [[], 1 => 9],
+            ],
+        ];
+    }
+
+    /**
+     * @param array $items
+     * @param string $path
+     * @param $expected
+     * @return void
+     * @dataProvider unsetPathProvider
+     */
+    public function testUnsetPath(array $items, string $path, $expected)
+    {
+        unset_path($items, $path);
+        $this->assertEquals($expected, $items);
+    }
 }