Skip to content

term::emit's writer argument does not behave additively wrt features. #389

@cwfitzgerald

Description

@cwfitzgerald

Originally reported as gfx-rs/wgpu#7915
Connected to #374
cc @bushrat011899

Hello! The writer argument to term::emit can cause compilation to fail when additional features are added. https://github.com/brendanzab/codespan/blob/master/codespan-reporting/src/term.rs#L28-L30 when there are no features enabled, you can pass in a String and it will compile. But enable the termcolor feature, a string will no longer be allowed. Similarly you can put a fmt::Write type which does not impl io::Write into the slot, which will cause a compilation failure when the std feature is added by another crate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions