Merge pull request #37 from brefphp/feature/optimize-heavy-dependencies-warning

Show a warning when using the AWS or Google SDK to optimize it

Author: mnapoli

src/Cli/IO.php

@@ -98,6 +98,11 @@ public static function error(Throwable $e, bool $logStackTrace = true): void
         ]);
     }
 
+    public static function warning(string $message): void
+    {
+        self::writeln(Styles::bold(Styles::bgYellow(' ! ')) . ' ' . Styles::yellow($message));
+    }
+
     public static function enableVerbose(): void
     {
         if (self::$verboseMode) return;

src/Commands/Deploy.php

@@ -15,6 +15,7 @@
 use Bref\Cli\Cli\IO;
 use Bref\Cli\Cli\Styles;
 use Bref\Cli\Components\ServerlessFramework;
+use Bref\Cli\Helpers\DependencyAnalyzer;
 use Exception;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -57,6 +58,15 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             sprintf("Deploying %s to environment %s", Styles::bold($appName), Styles::bold($environment)),
         ]);
 
+        $dependencyWarnings = DependencyAnalyzer::analyzeComposerDependencies();
+        if (!empty($dependencyWarnings)) {
+            IO::writeln('');
+            foreach ($dependencyWarnings as $warning) {
+                IO::warning($warning);
+            }
+            IO::writeln('');
+        }
+
         IO::spin('creating deployment');
 
         // Retrieve the current git ref and commit message to serve as a label for the deployment

src/Helpers/DependencyAnalyzer.php

@@ -0,0 +1,105 @@
+<?php declare(strict_types=1);
+
+namespace Bref\Cli\Helpers;
+
+use Exception;
+use JsonException;
+
+class DependencyAnalyzer
+{
+    /**
+     * @return string[]
+     */
+    public static function analyzeComposerDependencies(string $composerJsonPath = 'composer.json'): array
+    {
+        if (!file_exists($composerJsonPath)) {
+            return [];
+        }
+
+        try {
+            $composerContent = file_get_contents($composerJsonPath);
+            if ($composerContent === false) {
+                return [];
+            }
+
+            $composer = json_decode($composerContent, true, 512, JSON_THROW_ON_ERROR);
+            if (!is_array($composer)) {
+                return [];
+            }
+
+            $warnings = [];
+            $require = $composer['require'] ?? [];
+            
+            if (!is_array($require)) {
+                return [];
+            }
+
+            // Check for AWS SDK in composer.json or vendor directory
+            $hasAwsSdk = isset($require['aws/aws-sdk-php']) || 
+                         (is_dir('vendor/aws/aws-sdk-php') && file_exists('vendor/aws/aws-sdk-php/composer.json'));
+            
+            if ($hasAwsSdk) {
+                $isOptimized = self::isAwsSdkOptimized($composer);
+                if (!$isOptimized) {
+                    $warnings[] = 'AWS SDK detected - optimize your deployment size: https://github.com/aws/aws-sdk-php/tree/master/src/Script/Composer';
+                }
+            }
+
+            // Check for Google SDK in composer.json or vendor directory
+            $hasGoogleSdk = isset($require['google/apiclient']) || 
+                           (is_dir('vendor/google/apiclient') && file_exists('vendor/google/apiclient/composer.json'));
+            
+            if ($hasGoogleSdk) {
+                $isOptimized = self::isGoogleSdkOptimized($composer);
+                if (!$isOptimized) {
+                    $warnings[] = 'Google SDK detected - optimize your deployment size: https://github.com/googleapis/google-api-php-client#cleaning-up-unused-services';
+                }
+            }
+
+            return $warnings;
+
+        } catch (JsonException) {
+            return [];
+        }
+    }
+
+    /**
+     * Check if AWS SDK is optimized by looking for custom scripts or exclusions
+     * @param array<string, mixed> $composer
+     */
+    private static function isAwsSdkOptimized(array $composer): bool
+    {
+        // Check for AWS SDK optimization script
+        $scripts = $composer['scripts'] ?? [];
+        if (is_array($scripts) && isset($scripts['pre-autoload-dump'])) {
+            $preAutoloadDump = (array) $scripts['pre-autoload-dump'];
+            foreach ($preAutoloadDump as $script) {
+                if (is_string($script) && str_contains($script, 'Aws\\Script\\Composer\\Composer::removeUnusedServices')) {
+                    return true;
+                }
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Check if Google SDK is optimized by looking for custom exclusions
+     * @param array<string, mixed> $composer
+     */
+    private static function isGoogleSdkOptimized(array $composer): bool
+    {
+        // Check for Google SDK optimization script
+        $scripts = $composer['scripts'] ?? [];
+        if (is_array($scripts) && isset($scripts['pre-autoload-dump'])) {
+            $preAutoloadDump = (array) $scripts['pre-autoload-dump'];
+            foreach ($preAutoloadDump as $script) {
+                if (is_string($script) && str_contains($script, 'Google\\Task\\Composer::cleanup')) {
+                    return true;
+                }
+            }
+        }
+
+        return false;
+    }
+}