fix(nft): handle invalid Solana NFT image URLs

Author: onyb

app/api/nft/models.py

@@ -1,12 +1,13 @@
 from enum import Enum
+from typing import Any
 
 from pydantic import BaseModel, ConfigDict, Field, field_validator
 from pydantic.alias_generators import to_camel
 
 
 def strip_trailing_slash_validator(v: str | None) -> str | None:
     if v is not None:
-        return v.rstrip("/")
+        return v.strip().rstrip("/")
     return v
 
 
@@ -171,13 +172,16 @@ def validate_urls(cls, v: str) -> str:
 
 
 class SolanaAssetContentLink(BaseModel):
-    image: str | None = None
+    image: Any = None
     external_url: str | None = None
 
     @field_validator("image")
     @classmethod
-    def validate_urls(cls, v: str | None) -> str | None:
-        return strip_trailing_slash_validator(v)
+    def validate_image(cls, v: Any) -> str | None:
+        if isinstance(v, str):
+            return strip_trailing_slash_validator(v) or None
+
+        return None
 
     model_config = ConfigDict(
         extra="allow",

app/api/nft/test_routes.py

@@ -5,6 +5,7 @@
 
 from app.api.nft.models import (
     SimpleHashNFTResponse,
+    SolanaAssetContentLink,
     SolanaAssetMerkleProof,
 )
 from app.main import app
@@ -471,3 +472,25 @@ def capture_post_request(*args, **kwargs):
         {"contractAddress": "0x123", "tokenId": "456"},
         {"contractAddress": "0x789", "tokenId": "101112"},
     ]
+
+
+def test_solana_asset_content_link_image_validation():
+    # Test with boolean value - should convert to None
+    # Ref: https://github.com/brave/gate3/issues/72
+    link_false = SolanaAssetContentLink.model_validate({"image": False})
+    assert link_false.image is None
+
+    # Test with None - should remain None
+    link_none = SolanaAssetContentLink.model_validate({"image": None})
+    assert link_none.image is None
+
+    # Test with empty string - should convert to None
+    link_empty = SolanaAssetContentLink.model_validate({"image": ""})
+    assert link_empty.image is None
+
+    # Test with valid string - should apply URL validation
+    # Trailing slash and whitespaces should be stripped
+    link_string = SolanaAssetContentLink.model_validate(
+        {"image": "https://example.com/image.jpg/   "}
+    )
+    assert link_string.image == "https://example.com/image.jpg"