Skip to content

Commit 8d34baa

Browse files
samartnikcdesouza-chromium
authored andcommitted
[cr139][Android] New param for showBookmarkManager
Chromium changes: https://chromium.googlesource.com/chromium/src/+/3d31849766dd4afa2053e5a0c1561286bf86c142 commit 3d31849766dd4afa2053e5a0c1561286bf86c142 Author: Gazal Agarwal <agazal@google.com> Date: Wed Jun 11 21:07:09 2025 -0700 Open native pages in the adjacent tab Screen Recording: - FF enabled: http://screencast/cast/NTY4MDUzNzA0MDU4NDcwNHw0ODI2ZWYxMy0wZA - FF disabled: http://screencast/cast/NjMyOTcxNDQ4OTY4ODA2NHw5ODM0ZWZjNy1lOQ Bug: 405234523 Change-Id: I7f3361a65c7376b198d98dbfdbbf6dfb6de75441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6509925 Commit-Queue: Gazal Agarwal <agazal@google.com> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1472829}
1 parent 9de2f2d commit 8d34baa

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

android/java/org/chromium/chrome/browser/app/BraveActivity.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2417,9 +2417,9 @@ public void addOrEditBookmark(final Tab tabToBookmark) {
24172417
((TabBookmarker) mTabBookmarkerSupplier.get()).addOrEditBookmark(tabToBookmark);
24182418
}
24192419

2420-
public void showBookmarkManager(Profile profile) {
2420+
public void showBookmarkManager(Profile profile, Tab currentTab) {
24212421
if (mBookmarkManagerOpenerSupplier.get() != null) {
2422-
mBookmarkManagerOpenerSupplier.get().showBookmarkManager(this, profile);
2422+
mBookmarkManagerOpenerSupplier.get().showBookmarkManager(this, currentTab, profile);
24232423
}
24242424
}
24252425

android/java/org/chromium/chrome/browser/util/TabUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ public boolean onMenuItemClick(MenuItem item) {
157157
});
158158
return true;
159159
} else if (id == R.id.view_bookmarks) {
160-
activity.showBookmarkManager(currentTab.getProfile());
160+
activity.showBookmarkManager(currentTab.getProfile(), currentTab);
161161
return true;
162162
}
163163
return false;

0 commit comments

Comments
 (0)