You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is an override, namely, `URLRequestHttpJob::CreateCookieOptions`,
which is used to capture all calls to `CreateCookieOptions` declared in
the TUs annonymous namespace, and adding extra operations to it. This
override has recently broken as the annonymous namespace was moved into
the `net` namespace.
This change creates a trampoline function to allow the override we have
in `URLRequestHttpJob`, which has the same name, to call
`CreateCookieOptions` through this middle function with a differing
name.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/4395b43126e0dccea609c06e4294bea030c4d726
commit 4395b43126e0dccea609c06e4294bea030c4d726
Author: Adam Rice <ricea@chromium.org>
Date: Fri Jun 13 01:21:39 2025 -0700
net: Avoid unnecessary string construction
Fix a few places in //net where std::strings were constructed
unnecessarily.
Also inline the string constants in //net/http/http_auth_scheme.h so the
compiler can optimize them more easily.
Also wrap all of url_request_http_job.cc in namespace net and remove
unnecessary namespace qualifiers from that file.
Also use base::flat_set instead of std::set for sets that are always
small.
Change-Id: Id2ffa42ac058c9bcd1f11ddc662034b0caacf254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6622734
Auto-Submit: Adam Rice <ricea@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473415}
0 commit comments