Android zxcvbn component support
#29302
Conversation
szilardszaloki
force-pushed
the
szilard/46425-adds-zxcvbn-data-dictionaries-on-android
branch
from
996832a to
2bebe54
Compare
szilardszaloki
force-pushed
the
szilard/46425-adds-zxcvbn-data-dictionaries-on-android
branch
from
2bebe54 to
71d3c6f
Compare
| @@ -398,6 +398,8 @@ if (is_android) { | |||
| "//brave/browser/sync/brave_sync_devices_android.h", | |||
| "//chrome/browser/bookmarks/bookmark_html_writer.cc", | |||
| "//chrome/browser/bookmarks/bookmark_html_writer.h", | |||
| "//chrome/browser/component_updater/zxcvbn_data_component_installer.cc", | |||
There was a problem hiding this comment.
please create a new target for this and put it in brave/browser/component_updater/BUILD.gn
| @@ -35,6 +39,9 @@ void RegisterComponentsForUpdate() { | |||
| p3a::RegisterP3AComponent( | |||
| cus, p3a_service->remote_config_manager()->GetWeakPtr()); | |||
| } | |||
| #if BUILDFLAG(IS_ANDROID) | |||
There was a problem hiding this comment.
please add a comment here explaining that this is currently registered in upstream for !IS_ANDROID
| ] | ||
| deps += [ "//third_party/zxcvbn-cpp" ] | ||
| } | ||
| + import("//brave/components/password_manager/core/browser/ui/sources.gni") sources += brave_chrome_components_password_manager_core_browser_ui_sources deps += brave_chrome_components_password_manager_core_browser_ui_deps |
There was a problem hiding this comment.
It's not clear to me why we're adding these files back into this target because the usages are behind !BUILDFLAG(IS_ANDROID) flags anyway.
There was a problem hiding this comment.
I guess it's for https://github.com/brave/brave-core/pull/29330/files#diff-df18fbe668e1694e62a9825d180bd13b74b1b0243a3d291a8929e1c2ebda1e51R17 which calls it directly, but in that case it can be in it's own target in Brave and not have to patch here. Internally the target can have a public_dep on components/password_manager/core/browser/ui for !is_android and otherwise include the sources directly
Resolves brave/brave-browser#46425.