Merge pull request #349 from brave/forbid-adguard-cosmetic-modifiers

Forbid adguard cosmetic modifiers for now

Author: antonok-edm

src/filters/cosmetic.rs

@@ -40,6 +40,8 @@ pub enum CosmeticFilterError {
     HtmlFilteringUnsupported,
     #[error("scriptlet args could not be parsed")]
     InvalidScriptletArgs,
+    #[error("location modifiers are unsupported")]
+    LocationModifiersUnsupported,
 }
 
 /// Refer to <https://github.com/uBlockOrigin/uBlock-issues/wiki/Static-filter-syntax#action-operators>
@@ -179,6 +181,10 @@ impl CosmeticFilter {
         let mut hostnames_vec = vec![];
         let mut not_hostnames_vec = vec![];
 
+        if line.starts_with('[') {
+            return Err(CosmeticFilterError::LocationModifiersUnsupported);
+        }
+
         for (location_type, location) in Self::locations_before_sharp(line, sharp_index) {
             let mut hostname = String::new();
             if location.is_ascii() {

src/lists.rs

@@ -617,6 +617,16 @@ mod tests {
             let result = parse_filter(input, true, Default::default());
             assert!(result.is_ok());
         }
+        {
+            let input = "[$app=org.example.app]example.com##.textad";
+            let result = parse_filter(input, true, Default::default());
+            assert!(result.is_err());
+        }
+        {
+            let input = r#"[$domain=/^i\[a-z\]*\.strmrdr\[a-z\]+\..*/]##+js(set-constant, adscfg.enabled, false)"#;
+            let result = parse_filter(input, true, Default::default());
+            assert!(result.is_err());
+        }
     }
 
     #[test]