DefaultNSQLookup: accept an ObjectMapper

The recommended way to use ObjectMapper is to have a shared instance in
your application.

Author: Eivind Siqveland Larsen

src/main/java/com/github/brainlag/nsq/lookup/DefaultNSQLookup.java

@@ -14,6 +14,15 @@
 
 public class DefaultNSQLookup implements NSQLookup {
     Set<String> addresses = Sets.newHashSet();
+    private final ObjectMapper mapper;
+
+    public DefaultNSQLookup() {
+        this(new ObjectMapper());
+    }
+
+    public DefaultNSQLookup(ObjectMapper mapper) {
+        this.mapper = mapper;
+    }
 
     @Override
     public void addLookupAddress(String addr, int port) {
@@ -30,7 +39,6 @@ public Set<ServerAddress> lookup(String topic) {
 
         for (String addr : getLookupAddresses()) {
             try {
-                ObjectMapper mapper = new ObjectMapper();
                 String topicEncoded = URLEncoder.encode(topic, Charsets.UTF_8.name());
                 JsonNode jsonNode = mapper.readTree(new URL(addr + "/lookup?topic=" + topicEncoded));
                 LogManager.getLogger(this).debug("Server connection information: {}", jsonNode);

src/test/java/com/github/brainlag/nsq/NSQConsumerTest.java

@@ -21,7 +21,7 @@ public class NSQConsumerTest {
     @Test
     public void testLongRunningConsumer() throws NSQException, TimeoutException, InterruptedException {
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQConsumer consumer = new NSQConsumer(lookup, "test1", "testconsumer", (message) -> {

src/test/java/com/github/brainlag/nsq/NSQProducerTest.java

@@ -1,5 +1,6 @@
 package com.github.brainlag.nsq;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
 import com.github.brainlag.nsq.exceptions.NSQException;
 import com.github.brainlag.nsq.lookup.DefaultNSQLookup;
 import com.github.brainlag.nsq.lookup.NSQLookup;
@@ -27,6 +28,7 @@
 import static org.junit.Assert.assertTrue;
 
 public class NSQProducerTest {
+    private ObjectMapper mapper = new ObjectMapper();
 
     private NSQConfig getSnappyConfig() {
         final NSQConfig config = new NSQConfig();
@@ -68,7 +70,7 @@ private NSQConfig getSslAndDeflateConfig() throws SSLException {
     @Test
     public void testProduceOneMsgSnappy() throws NSQException, TimeoutException, InterruptedException {
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQProducer producer = new NSQProducer();
@@ -96,7 +98,7 @@ public void testProduceOneMsgSnappy() throws NSQException, TimeoutException, Int
     public void testProduceOneMsgDeflate() throws NSQException, TimeoutException, InterruptedException {
         System.setProperty("io.netty.noJdkZlibDecoder", "false");
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQProducer producer = new NSQProducer();
@@ -123,7 +125,7 @@ public void testProduceOneMsgDeflate() throws NSQException, TimeoutException, In
     @Test
     public void testProduceOneMsgSsl() throws InterruptedException, NSQException, TimeoutException, SSLException {
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQProducer producer = new NSQProducer();
@@ -150,7 +152,7 @@ public void testProduceOneMsgSsl() throws InterruptedException, NSQException, Ti
     @Test
     public void testProduceOneMsgSslAndSnappy() throws InterruptedException, NSQException, TimeoutException, SSLException {
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQProducer producer = new NSQProducer();
@@ -178,7 +180,7 @@ public void testProduceOneMsgSslAndSnappy() throws InterruptedException, NSQExce
     public void testProduceOneMsgSslAndDeflat() throws InterruptedException, NSQException, TimeoutException, SSLException {
         System.setProperty("io.netty.noJdkZlibDecoder", "false");
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQProducer producer = new NSQProducer();
@@ -206,7 +208,7 @@ public void testProduceOneMsgSslAndDeflat() throws InterruptedException, NSQExce
     @Test
     public void testProduceMoreMsg() throws NSQException, TimeoutException, InterruptedException {
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQConsumer consumer = new NSQConsumer(lookup, "test3", "testconsumer", (message) -> {
@@ -235,7 +237,7 @@ public void testProduceMoreMsg() throws NSQException, TimeoutException, Interrup
     @Test
     public void testParallelProducer() throws NSQException, TimeoutException, InterruptedException {
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQConsumer consumer = new NSQConsumer(lookup, "test3", "testconsumer", (message) -> {
@@ -271,7 +273,7 @@ public void testParallelProducer() throws NSQException, TimeoutException, Interr
     @Test
     public void testMultiMessage() throws NSQException, TimeoutException, InterruptedException {
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQConsumer consumer = new NSQConsumer(lookup, "test3", "testconsumer", (message) -> {
@@ -301,7 +303,7 @@ public void testMultiMessage() throws NSQException, TimeoutException, Interrupte
     @Test
     public void testBackoff() throws InterruptedException, NSQException, TimeoutException {
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQConsumer consumer = new NSQConsumer(lookup, "test3", "testconsumer", (message) -> {
@@ -335,7 +337,7 @@ public void testBackoff() throws InterruptedException, NSQException, TimeoutExce
     @Test
     public void testScheduledCallback() throws NSQException, TimeoutException, InterruptedException {
         AtomicInteger counter = new AtomicInteger(0);
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQConsumer consumer = new NSQConsumer(lookup, "test3", "testconsumer", (message) -> {});
@@ -349,7 +351,7 @@ public void testScheduledCallback() throws NSQException, TimeoutException, Inter
 
     @Test
     public void testEphemeralTopic() throws InterruptedException, NSQException, TimeoutException {
-        NSQLookup lookup = new DefaultNSQLookup();
+        NSQLookup lookup = new DefaultNSQLookup(mapper);
         lookup.addLookupAddress(Nsq.getNsqLookupdHost(), 4161);
 
         NSQProducer producer = new NSQProducer();