Build dependency issue on main branch?

[mattzque]

I'm sure I just don't understand something, but when I try to install pottery via git I get this error:

% pip install 'git+https://github.com/brainix/pottery.git'         
Collecting git+https://github.com/brainix/pottery.git
  Cloning https://github.com/brainix/pottery.git to /tmp/pip-req-build-7o_cy9ds
  Running command git clone --filter=blob:none --quiet https://github.com/brainix/pottery.git /tmp/pip-req-build-7o_cy9ds
  Resolved https://github.com/brainix/pottery.git to commit 602598242694d62b31c3a62eac08334aa51d4164
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      Traceback (most recent call last):
        File "/home/user/.pyenv/versions/3.12.6/envs/testing/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/user/.pyenv/versions/3.12.6/envs/testing/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/home/user/.pyenv/versions/3.12.6/envs/testing/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-7pqwmh0z/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 334, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-7pqwmh0z/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 304, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-7pqwmh0z/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 522, in run_setup
          super().run_setup(setup_script=setup_script)
        File "/tmp/pip-build-env-7pqwmh0z/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 320, in run_setup
          exec(code, locals())
        File "<string>", line 24, in <module>
        File "/tmp/pip-req-build-7o_cy9ds/pottery/__init__.py", line 47, in <module>
          from .exceptions import PotteryError  # isort:skip
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-req-build-7o_cy9ds/pottery/exceptions.py", line 27, in <module>
          from redis import Redis
      ModuleNotFoundError: No module named 'redis'
      [end of output]

The error originates from the setup.py file which imports pottery itself, it tries to import redis, but redis isn't available at this point and the build dependencies are declared within setup.py itself? I (seemingly) fixed it by removing the import from setup.py.

Is this a bug? Or did I not install it correctly?

[mattzque]

Fixed! Thanks @brainix

[brainix]

Thank you for the detailed bug report, and also for your patience.