Skip to content

Commit 15d90a0

Browse files
replace upip ulogging installation with ulogging file in tests folder
1 parent 2646996 commit 15d90a0

12 files changed

+269
-13
lines changed

Dockerfile.client_rtu

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,4 @@ FROM micropython/unix:v1.18
1010
# COPY ./ /home
1111
# COPY umodbus /root/.micropython/lib/umodbus
1212

13-
RUN micropython-dev -m upip install micropython-ulogging
14-
1513
CMD [ "micropython-dev", "-m", "examples/rtu_client_example.py" ]

Dockerfile.client_tcp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,4 @@ FROM micropython/unix:v1.18
1010
# COPY ./ /home
1111
# COPY umodbus /root/.micropython/lib/umodbus
1212

13-
RUN micropython-dev -m upip install micropython-ulogging
14-
1513
CMD [ "micropython-dev", "-m", "examples/tcp_client_example.py" ]

Dockerfile.host_rtu

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,4 @@ FROM micropython/unix:v1.18
1010
# COPY ./ /home
1111
# COPY umodbus /root/.micropython/lib/umodbus
1212

13-
RUN micropython-dev -m upip install micropython-ulogging
14-
1513
CMD [ "micropython-dev", "-m", "examples/rtu_host_example.py" ]

Dockerfile.host_tcp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,4 @@ FROM micropython/unix:v1.18
1010
# COPY ./ /home
1111
# COPY umodbus /root/.micropython/lib/umodbus
1212

13-
RUN micropython-dev -m upip install micropython-ulogging
14-
1513
CMD [ "micropython-dev", "-m", "examples/tcp_host_example.py" ]

Dockerfile.test_examples

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,3 @@ FROM micropython/unix:v1.18
1111
# COPY ./ /home
1212
# COPY umodbus /root/.micropython/lib/umodbus
1313
# COPY mpy_unittest.py /root/.micropython/lib/mpy_unittest.py
14-
15-
RUN micropython-dev -m upip install micropython-ulogging

Dockerfile.tests

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ COPY ./ /home
1212
COPY registers/example.json /home/tests/test-registers.json
1313
COPY umodbus /root/.micropython/lib/umodbus
1414
COPY mpy_unittest.py /root/.micropython/lib/mpy_unittest.py
15+
COPY tests/ulogging.py /root/.micropython/lib/ulogging.py
1516

16-
RUN micropython-dev -m upip install micropython-ulogging
1717
RUN micropython-dev -c "import mpy_unittest as unittest; unittest.main('tests')"
1818

1919
ENTRYPOINT ["/bin/bash"]

Dockerfile.tests_manually

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ COPY ./ /home
1212
COPY registers/example.json /home/tests/test-registers.json
1313
COPY umodbus /root/.micropython/lib/umodbus
1414
COPY mpy_unittest.py /root/.micropython/lib/mpy_unittest.py
15-
16-
RUN micropython-dev -m upip install micropython-ulogging
15+
COPY tests/ulogging.py /root/.micropython/lib/ulogging.py
1716

1817
ENTRYPOINT ["/bin/bash"]

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2323

2424
### Changed
2525
- `umodbus/version.py` file is validated against the latest changelog entry before running all tests and testing the package creation
26+
- `ulogging` placed into `tests` folder instead of installing it with deprecated `upip` in all Docker containers
2627

2728
### Fixed
2829
- Added missing empty line in several files

docker-compose-rtu-test.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ services:
2020
- ./registers:/home/registers
2121
- ./umodbus:/root/.micropython/lib/umodbus
2222
- ./fakes:/usr/lib/micropython
23+
- ./tests/ulogging.py:/root/.micropython/lib/ulogging.py
2324
expose:
2425
- "65433"
2526
ports:
@@ -41,6 +42,7 @@ services:
4142
- ./umodbus:/root/.micropython/lib/umodbus
4243
- ./fakes:/usr/lib/micropython
4344
- ./mpy_unittest.py:/root/.micropython/lib/mpy_unittest.py
45+
- ./tests/ulogging.py:/root/.micropython/lib/ulogging.py
4446
depends_on:
4547
- micropython-client
4648
command:

docker-compose-rtu.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ services:
1919
- ./:/home
2020
- ./umodbus:/root/.micropython/lib/umodbus
2121
- ./fakes:/usr/lib/micropython
22+
- ./tests/ulogging.py:/root/.micropython/lib/ulogging.py
2223
expose:
2324
- "65433"
2425
ports:
@@ -39,6 +40,7 @@ services:
3940
- ./:/home
4041
- ./umodbus:/root/.micropython/lib/umodbus
4142
- ./fakes:/usr/lib/micropython
43+
- ./tests/ulogging.py:/root/.micropython/lib/ulogging.py
4244
depends_on:
4345
- micropython-client
4446
networks:

0 commit comments

Comments
 (0)