Skip to content

Commit f1ad452

Browse files
Stephan Wentzpl-github
authored andcommitted
fix: Support sentry 4.x
BREAKING CHANGE: Only supports sentry 4.6.1+
1 parent 5b57d21 commit f1ad452

8 files changed

+31
-35
lines changed

composer.json

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,28 @@
66
"require": {
77
"php": "^8.2",
88
"ext-iconv": "*",
9-
"bgalati/monolog-sentry-handler": "^2.0",
9+
"bgalati/monolog-sentry-handler": "^2.1",
1010
"jean85/pretty-package-versions": "^2.0",
1111
"monolog/monolog": "^3.0",
1212
"nyholm/psr7": "^1.2.1",
1313
"psr/log": "^1.1|^2.0|^3.0",
14-
"sentry/sentry": "^3.1|^4.0",
15-
"symfony/config": "^6.2|^7.0",
16-
"symfony/dependency-injection": "^6.2|^7.0",
17-
"symfony/http-client": "^6.2|^7.0",
18-
"symfony/http-kernel": "^6.2|^7.0",
19-
"symfony/yaml": "^6.2|^7.0"
14+
"sentry/sentry": "^4.6.1",
15+
"symfony/config": "^6.4|^7.0",
16+
"symfony/dependency-injection": "^6.4|^7.0",
17+
"symfony/http-client": "^6.4|^7.0",
18+
"symfony/http-kernel": "^6.4|^7.0",
19+
"symfony/yaml": "^6.4|^7.0"
2020
},
2121
"require-dev": {
22-
"brainbits/phpcs-standard": "^7.0",
23-
"ergebnis/phpstan-rules": "^2.0",
24-
"nyholm/nsa": "^1.2",
25-
"phpstan/phpstan": "^1.8",
26-
"phpstan/phpstan-phpunit": "^1.1",
27-
"phpunit/phpunit": "^10.1",
28-
"symfony/console": "^6.2|^7.0",
29-
"symfony/messenger": "^6.2|^7.0",
30-
"symfony/security-bundle": "^6.2|^7.0",
22+
"brainbits/phpcs-standard": "^7.0.1",
23+
"ergebnis/phpstan-rules": "^2.2",
24+
"nyholm/nsa": "^1.3",
25+
"phpstan/phpstan": "^1.10.59",
26+
"phpstan/phpstan-phpunit": "^1.3.16",
27+
"phpunit/phpunit": "^11.0.4",
28+
"symfony/console": "^6.4|^7.0.4",
29+
"symfony/messenger": "^6.4|^7.0.4",
30+
"symfony/security-bundle": "^6.4|^7.0.4",
3131
"thecodingmachine/phpstan-strict-rules": "^1.0"
3232
},
3333
"suggest": {

phpunit.xml.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0"?>
2-
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" colors="true" bootstrap="vendor/autoload.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.2/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
2+
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" colors="true" bootstrap="vendor/autoload.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.0/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
33
<coverage/>
44
<testsuite name="sentry-bundle">
55
<directory>tests</directory>

src/SentryFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ public function create(
4949
'in_app_exclude' => $inAppExclude ?? [],
5050
'prefixes' => $prefixes ?? [],
5151
'release' => $release,
52+
'attach_stacktrace' => false,
5253
'default_integrations' => false,
53-
'send_attempts' => 1,
5454
'integrations' => [
5555
new RequestIntegration(),
5656
new EnvironmentIntegration(),

tests/EventListener/MonologResetterEventListenerTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,15 @@
66

77
use Brainbits\MonologSentry\EventListener\MonologResetterEventListener;
88
use InvalidArgumentException;
9+
use PHPUnit\Framework\Attributes\CoversClass;
910
use PHPUnit\Framework\TestCase;
1011
use Psr\Log\LoggerInterface;
1112
use stdClass;
1213
use Symfony\Component\Messenger\Envelope;
1314
use Symfony\Component\Messenger\Event\WorkerMessageFailedEvent;
1415
use Symfony\Component\Messenger\Event\WorkerMessageHandledEvent;
1516

16-
/** @covers \Brainbits\MonologSentry\EventListener\MonologResetterEventListener */
17+
#[CoversClass(MonologResetterEventListener::class)]
1718
final class MonologResetterEventListenerTest extends TestCase
1819
{
1920
use HubExpections;

tests/EventListener/SentryConsoleListenerTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
use Brainbits\MonologSentry\EventListener\SentryConsoleListener;
88
use Exception;
9+
use PHPUnit\Framework\Attributes\CoversClass;
910
use PHPUnit\Framework\MockObject\MockObject; // phpcs:ignore SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse
1011
use PHPUnit\Framework\TestCase;
1112
use Psr\Log\LoggerInterface;
@@ -18,7 +19,7 @@
1819
use Symfony\Component\Console\Input\StringInput;
1920
use Symfony\Component\Console\Output\NullOutput;
2021

21-
/** @covers \Brainbits\MonologSentry\EventListener\SentryConsoleListener */
22+
#[CoversClass(SentryConsoleListener::class)]
2223
final class SentryConsoleListenerTest extends TestCase
2324
{
2425
use HubExpections;

tests/EventListener/SentryRequestListenerTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace Brainbits\MonologSentryTests\EventListener;
66

77
use Brainbits\MonologSentry\EventListener\SentryRequestListener;
8+
use PHPUnit\Framework\Attributes\CoversClass;
89
use PHPUnit\Framework\MockObject\MockObject; // phpcs:ignore SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse
910
use PHPUnit\Framework\TestCase;
1011
use Psr\Log\LoggerInterface;
@@ -17,7 +18,7 @@
1718
use Symfony\Component\HttpKernel\Kernel;
1819
use Symfony\Component\HttpKernel\KernelEvents;
1920

20-
/** @covers \Brainbits\MonologSentry\EventListener\SentryRequestListener */
21+
#[CoversClass(SentryRequestListener::class)]
2122
final class SentryRequestListenerTest extends TestCase
2223
{
2324
use HubExpections;

tests/EventListener/SentryUserListenerTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace Brainbits\MonologSentryTests\EventListener;
66

77
use Brainbits\MonologSentry\EventListener\SentryUserListener;
8+
use PHPUnit\Framework\Attributes\CoversClass;
89
use PHPUnit\Framework\MockObject\MockObject; // phpcs:ignore SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse
910
use PHPUnit\Framework\TestCase;
1011
use Sentry\State\HubInterface;
@@ -17,7 +18,7 @@
1718
use Symfony\Component\HttpKernel\KernelEvents;
1819
use Symfony\Component\Security\Core\User\InMemoryUser;
1920

20-
/** @covers \Brainbits\MonologSentry\EventListener\SentryUserListener */
21+
#[CoversClass(SentryUserListener::class)]
2122
final class SentryUserListenerTest extends TestCase
2223
{
2324
use HubExpections;

tests/SentryFactoryTest.php

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,18 @@
55
namespace Brainbits\MonologSentryTests;
66

77
use Brainbits\MonologSentry\SentryFactory;
8-
use Http\Client\Common\PluginClient;
98
use Nyholm\NSA;
9+
use PHPUnit\Framework\Attributes\CoversClass;
1010
use PHPUnit\Framework\TestCase;
1111
use Psr\Log\LoggerInterface;
1212
use Sentry\Client;
1313
use Sentry\Dsn;
14+
use Sentry\HttpClient\HttpClient;
1415
use Sentry\Options;
1516
use Sentry\SentrySdk;
1617
use Sentry\State\Layer;
1718
use Sentry\Transport\HttpTransport;
18-
use Sentry\Transport\NullTransport;
19-
use Symfony\Component\HttpClient\HttplugClient;
2019
use Symfony\Component\HttpKernel\Kernel;
21-
use Symfony\Contracts\HttpClient\HttpClientInterface;
2220

2321
use function assert;
2422
use function is_array;
@@ -27,7 +25,7 @@
2725
use const PHP_SAPI;
2826
use const PHP_VERSION;
2927

30-
/** @covers \Brainbits\MonologSentry\SentryFactory */
28+
#[CoversClass(SentryFactory::class)]
3129
final class SentryFactoryTest extends TestCase
3230
{
3331
public function testClientHasExpectedServices(): void
@@ -67,13 +65,7 @@ public function testClientHasExpectedServices(): void
6765
self::assertSame(['_projectDir'], $options->getPrefixes());
6866

6967
$pluginClient = NSA::getProperty($transport, 'httpClient');
70-
self::assertInstanceOf(PluginClient::class, $pluginClient);
71-
72-
$httplugClient = NSA::getProperty($pluginClient, 'client');
73-
self::assertInstanceOf(HttplugClient::class, $httplugClient);
74-
75-
$httpClient = NSA::getProperty($httplugClient, 'client');
76-
self::assertInstanceOf(HttpClientInterface::class, $httpClient);
68+
self::assertInstanceOf(HttpClient::class, $pluginClient);
7769

7870
$hub = SentrySdk::getCurrentHub();
7971
$stack = NSA::getProperty($hub, 'stack');
@@ -108,7 +100,7 @@ public function testMinimalParameters(): void
108100
self::assertInstanceOf(Client::class, $client);
109101

110102
$transport = NSA::getProperty($client, 'transport');
111-
self::assertInstanceOf(NullTransport::class, $transport);
103+
self::assertInstanceOf(HttpTransport::class, $transport);
112104

113105
$options = $client->getOptions();
114106
self::assertInstanceOf(Options::class, $options);

0 commit comments

Comments
 (0)