Made some changes that seem to work, how do I handle pull request? #73
perigvennetier
started this conversation in
General
Replies: 1 comment
-
Pull request in draft. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @boyan-soubachov, @bandwiches,
I made some changes in a cloned repo to the example.py and quite a few other files to run more examples, I added more useful data to current classes, added some comment throughout:
(1) It passes all the current tests
but
(2) I've added some new files and classes, used in the example.py file but I don't know how to create new tests for these
(3) I added the use of pandas in the example.py to store lots of data (like repeated streamer quotes) in dataframes, is that acceptable?
(4) Do I just submit a pull request for all the changes all at once or should it be done in smaller chunks? (never submitted a pull request before)
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions