Remove Plural Entries Missing the 'Other' Form

Not having the 'other' form in plural resources can cause the app to crash.

This commit ensures that any plural entries lacking the 'other' form are removed to prevent crashes.

Author: ja-openai

common/src/main/java/com/box/l10n/mojito/okapi/filters/AndroidFilter.java

@@ -502,9 +502,17 @@ public String execute(String xmlContent) {
           Element plurals = (Element) pluralsElements.item(i);
           NodeList items = plurals.getElementsByTagName("item");
           boolean hasTranslated = false;
+          boolean hasOther = false;
 
           for (int j = 0; j < items.getLength(); j++) {
             Element item = (Element) items.item(j);
+
+            if ("other".equals(item.getAttribute("quantity"))) {
+              hasOther =
+                  !RemoveUntranslatedStrategy.UNTRANSLATED_PLACEHOLDER.equals(
+                      item.getTextContent());
+            }
+
             if (hasRemoveUntranslated()
                 && item.getTextContent()
                     .equals(RemoveUntranslatedStrategy.UNTRANSLATED_PLACEHOLDER)) {
@@ -515,7 +523,7 @@ public String execute(String xmlContent) {
             }
           }
 
-          if (!hasTranslated) {
+          if (!hasOther || !hasTranslated) {
             plurals.getParentNode().removeChild(plurals);
             i--;
           }

common/src/test/java/com/box/l10n/mojito/okapi/filters/AndroidFilterTest.java

@@ -268,6 +268,51 @@ public void testPostProcessingRemoveTranslatableFalse() {
     assertEquals(expected, output);
   }
 
+  @Test
+  public void testPostProcessingRemoveMissingOther() {
+    AndroidFilter.AndroidFilePostProcessor androidFilePostProcessor =
+        new AndroidFilter.AndroidFilePostProcessor(true, true, 2, true, false);
+    String input =
+        """
+          <?xml version="1.0" encoding="UTF-8"?>
+          <resources>
+              <plurals name="pins">
+                  <item quantity="one">pin fr</item>
+              </plurals>
+          </resources>
+          """;
+    String output = androidFilePostProcessor.execute(input);
+    String expected =
+        """
+           <?xml version="1.0" encoding="UTF-8"?>
+           <resources/>
+           """;
+    assertEquals(expected, output);
+  }
+
+  @Test
+  public void testPostProcessingRemoveMissingOtherUntranslated() {
+    AndroidFilter.AndroidFilePostProcessor androidFilePostProcessor =
+        new AndroidFilter.AndroidFilePostProcessor(true, true, 2, true, false);
+    String input =
+        """
+          <?xml version="1.0" encoding="UTF-8"?>
+          <resources>
+              <plurals name="pins">
+                  <item quantity="one">pin fr</item>
+                  <item quantity="other">@#$untranslated$#@</item>
+              </plurals>
+          </resources>
+          """;
+    String output = androidFilePostProcessor.execute(input);
+    String expected =
+        """
+           <?xml version="1.0" encoding="UTF-8"?>
+           <resources/>
+           """;
+    assertEquals(expected, output);
+  }
+
   @Test
   public void testPostProcessingStandaloneNo() {
     AndroidFilter.AndroidFilePostProcessor androidFilePostProcessor =