Skip to content

minApprovals considers CONTRIBUTOR to be "less than" MEMBER #874

@sebastiankirsch

Description

@sebastiankirsch

Hey there, I'm having trouble configuring probot so it matches our use case.

Here's my configuration:

minApprovals:
  MEMBER: 2

For an example PR, I get 2 approvals from what are MEMBERs according to https://developer.github.com/v4/enum/commentauthorassociation/
Yet, the approvers are reported as CONTRIBUTORs - which is correct for that particular repo.

Unfortunately, it seems probot considers contributors to be "less than" members. I see how that makes sense for public repositories - yet in our case (internal repo of an organization), this is at least unexpected and/or misleading.

I understand that this is a tricky thing to solve, yet I still believe it's a mismatch between what github considers to be "more valueable" and Probot does...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions