Test with ACF Pro v6.3.11, WordPress 6.7.1, PHP 8.4 and PHPUnit 10 & 11

[bobbingwide]

ACF Pro v6.3.11 was released on 11 Nov 2024.
We need to test the Field blocks for ACF Pro plugin with the latest version and WordPress 6.7.1

[bobbingwide]

I couldn't remember how to get the PHPUnit tests to run, but I did test the examples for the Field block on s.b/oikcom.
No messages produced in the PHP error log, once the latest problem in #19 had been fixed.

[bobbingwide]

I managed to get the PHPUnit tests to run but they failed
since the generated <div> tag included an unexpected class of align.

This doesn't appear with WordPress 6.6.2. I must have been a change in WordPress 6.7, but I can't yet find out what caused this change. If it's intentional then I'll have to update the test cases to cater for this extra class and/or change the code to ignore the align attribute when it's blank.

Trace output shows that the align class is added by get_block_wrapper_attributes().

C:\apache\htdocs\wordpress\wp-content\plugins\field-block-for-acf-pro\includes\class-acf-field-block-renderer.php(122:0) acf_field_block_renderer::render_acf_field_classes(2) 785 0 2024-12-01T17:02:46+00:00 6.808113 0.000357 cf=the_content,acf_block_render_template 17201 59 19196 60817408/60817408 1024M F=947 en_US classes default output handler,default output handler
acf-field-field_64aa869f48df7 acf-type-text has-text-align-
C:\apache\htdocs\wordpress\wp-content\plugins\field-block-for-acf-pro\includes\class-acf-field-block-renderer.php(126:0) acf_field_block_renderer::render_acf_field_classes(3) 786 0 2024-12-01T17:02:46+00:00 6.808511 0.000398 cf=the_content,acf_block_render_template 17203 59 19196 60817408/60817408 1024M F=947 en_US attrs default output handler,default output handler
class="acf-field-field_64aa869f48df7 acf-type-text has-text-align- align wp-block-acf-field-acf-field"

The align wp-block-acf-field-acf-field string is returned in the $new_attributes array from the call to
WP_Block_Supports::get_instance()->apply_block_supports();

We need to determine what change was made to apply_block_supports() therefore.

[bobbingwide]

The change appears to have been made for https://core.trac.wordpress.org/ticket/62114
entitled: Default attribute value not used with get_block_wrapper_attributes
The fix

Ensures that the default values defined in the schema for block attributes are used when rendering the output of the block with get_block_wrapper_attributes helper.

In the $block parameter passed to render_acf_field_classes() we can see the default values for the attributes.
For align it's an empty string.

Extract from the trace output.

 [attributes] => Array

            [name] => Array

                [type] => (string) "string"
                [default] => (string) ""

            [data] => Array

                [type] => (string) "object"
                [default] => Array

            [align] => *RECURSION* name 2
            [mode] => *RECURSION* name 2

These attributes are defined by logic in ACF PRO.
I don't think we can do anything about this.
Therefore, it would appear that I need to change all the test cases which are affected by adding the new class align into the expected output files.

[bobbingwide]

test_image_field_render_post_field_set failed since the sizes attribute on the <img> tag now includes auto as the first value.
I don't really care if this is a WordPress 6.7 or ACF PRO change. I'll just update the expected results.