Lint

Author: boardfish

lib/nvar.rb

@@ -12,7 +12,7 @@ module Nvar
 
   # Comments in .env files must have a leading '#' symbol. This cannot be
   # followed by a space.
-  ENV_COMMENT = <<~'COMMENT'
+  ENV_COMMENT = <<~COMMENT
     #Environment variables are managed through this file (.env). The Scripts to
     #Rule Them All (in script/) load the environment from here, and the app warns
     #on startup if any required environment variables are missing. You can see the
@@ -93,7 +93,7 @@ def all_required_env_variables_set?
     end
 
     def variables
-      (YAML.safe_load(File.read(config_file_path)) || {}).deep_symbolize_keys
+      (YAML.safe_load_file(config_file_path) || {}).deep_symbolize_keys
     end
   end
 end

lib/nvar/engine.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require "rails"
-require_relative "./environment_variable"
+require_relative "environment_variable"
 
 module Nvar
   class Engine < Rails::Engine # :nodoc:

lib/nvar/environment_variable.rb

@@ -76,7 +76,7 @@ def typecast_value
     end
 
     def fetch_value(passthrough: false, default_value: nil)
-      return (default_value || name) if ENV["RAILS_ENV"] == "test" && !passthrough
+      return default_value || name if ENV["RAILS_ENV"] == "test" && !passthrough
 
       required ? ENV.fetch(name.to_s) : ENV[name.to_s]
     end