Skip to content

Commit 467b38f

Browse files
committed
🐛(helm) charts generate invalid YAML for collaboration API / WS
Closes suitenumerique#890 Remove the service blocks outside the conditionals in the collaboration API and WS templates.
1 parent 419079a commit 467b38f

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ and this project adheres to
1313
- 🚸(backend) make document search on title accent-insensitive #874
1414
- 🚩 add homepage feature flag #861
1515

16+
## Fixed
17+
18+
- 🐛(helm) charts generate invalid YAML for collaboration API / WS #890
1619

1720
## [3.1.0] - 2025-04-07
1821

src/helm/impress/templates/ingress_collaboration_api.yaml

-4
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ spec:
5151
pathType: ImplementationSpecific
5252
{{- end }}
5353
backend:
54-
service:
55-
name: {{ include "impress.yProvider.fullname" . }}
56-
port:
57-
number: {{ .Values.yProvider.service.port }}
5854
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
5955
service:
6056
name: {{ include "impress.yProvider.fullname" . }}

src/helm/impress/templates/ingress_collaboration_ws.yaml

-4
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ spec:
5151
pathType: ImplementationSpecific
5252
{{- end }}
5353
backend:
54-
service:
55-
name: {{ include "impress.yProvider.fullname" . }}
56-
port:
57-
number: {{ .Values.yProvider.service.port }}
5854
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
5955
service:
6056
name: {{ include "impress.yProvider.fullname" . }}

0 commit comments

Comments
 (0)