Add MPEG-TS recording support for streams with KLV metadata #4664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working through the existing tests, and also will add ones for this feature. I wanted to go ahead and tender the feature idea though and get feedback, please let me know if this is feasible! |
zach-grant-skydio
force-pushed
the
zach/AddRecordingSupportForMPEGTSwKLV
branch
2 times, most recently
from
1ab1c0a to
3f663ef
Compare
This commit adds support for recording MPEG-TS streams that contain KLV metadata or other unsupported elementary streams. Previously, the recorder would fail when encountering such streams with the message "no supported tracks found, skipping recording". Key changes: - Implement a passthrough recorder for MPEG-TS that writes raw stream data directly to disk without trying to process unsupported elementary streams - Modify the recorder to automatically use passthrough mode when unsupported codecs are detected - Update the MPEG-TS reader to properly extract and forward raw MPEG-TS data using Generic units with RTP packets This allows MediaMTX to gracefully handle MPEG-TS streams with KLV metadata by preserving the original stream structure and writing it directly to disk.
zach-grant-skydio
force-pushed
the
zach/AddRecordingSupportForMPEGTSwKLV
branch
from
3f663ef to
1cc527a
Compare
|
Closing in favor of a simpler approach: #4669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for recording MPEG-TS streams that contain KLV metadata or other unsupported elementary streams. Previously, the recorder would fail when encountering such streams with the message "no supported tracks found, skipping recording".
Key changes:
This allows MediaMTX to gracefully handle MPEG-TS streams with KLV metadata by preserving the original stream structure and writing it directly to disk.