bump golangci-lint (#250)

aler9 · web-flow · commit a3cde76e24ee · 2025-05-23T14:53:33.000+02:00
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -17,9 +17,9 @@ jobs:
       with:
         go-version: "1.24"
 
-    - uses: golangci/golangci-lint-action@v3
+    - uses: golangci/golangci-lint-action@v8
       with:
-        version: v1.64.5
+        version: v2.1.6
 
   go-mod-tidy:
     runs-on: ubuntu-22.04
diff --git a/.golangci.yml b/.golangci.yml
@@ -1,73 +1,75 @@
+version: "2"
+
 linters:
   enable:
   - asciicheck
   - bidichk
   - bodyclose
-  #- contextcheck
   - copyloopvar
   - dupl
   - errorlint
   - gochecknoinits
   - gocritic
-  - gofmt
-  - gofumpt
   - lll
   - misspell
   - nilerr
   - prealloc
   - predeclared
+  - reassign
   - revive
   - usestdlibvars
   - unconvert
-  #- usetesting
   - tparallel
   - wastedassign
   - whitespace
 
-issues:
-  exclude-use-default: false
+  settings:
+    errcheck:
+      exclude-functions:
+      - io.Copy
+      - (io.Closer).Close
+      - (io.Writer).Write
+      - (hash.Hash).Write
+      - (net.Conn).Close
+      - (net.Conn).SetReadDeadline
+      - (net.Conn).SetWriteDeadline
+      - (*net.TCPConn).SetKeepAlive
+      - (*net.TCPConn).SetKeepAlivePeriod
+      - (*net.TCPConn).SetNoDelay
+      - (net.Listener).Close
+      - (net.PacketConn).Close
+      - (net.PacketConn).SetReadDeadline
+      - (net.PacketConn).SetWriteDeadline
+      - (net/http.ResponseWriter).Write
+      - (*net/http.Server).Serve
+      - (*net/http.Server).ServeTLS
+      - (*net/http.Server).Shutdown
+      - os.Chdir
+      - os.Mkdir
+      - os.MkdirAll
+      - os.Remove
+      - os.RemoveAll
+      - os.Setenv
+      - os.Unsetenv
+      - (*os.File).WriteString
+      - (*os.File).Close
+      - (github.com/datarhei/gosrt.Conn).Close
+      - (github.com/datarhei/gosrt.Conn).SetReadDeadline
+      - (github.com/datarhei/gosrt.Conn).SetWriteDeadline
+      - (*github.com/bluenviron/gortsplib/v4.Client).Close
+      - (*github.com/bluenviron/gortsplib/v4.Server).Close
+      - (*github.com/bluenviron/gortsplib/v4.ServerSession).Close
+      - (*github.com/bluenviron/gortsplib/v4.ServerStream).Close
+      - (*github.com/bluenviron/gortsplib/v4.ServerConn).Close
 
-linters-settings:
-  errcheck:
-    exclude-functions:
-    - io.Copy
-    - (io.Closer).Close
-    - (io.Writer).Write
-    - (hash.Hash).Write
-    - (net.Conn).Close
-    - (net.Conn).SetReadDeadline
-    - (net.Conn).SetWriteDeadline
-    - (*net.TCPConn).SetKeepAlive
-    - (*net.TCPConn).SetKeepAlivePeriod
-    - (*net.TCPConn).SetNoDelay
-    - (net.Listener).Close
-    - (net.PacketConn).Close
-    - (net.PacketConn).SetReadDeadline
-    - (net.PacketConn).SetWriteDeadline
-    - (net/http.ResponseWriter).Write
-    - (*net/http.Server).Serve
-    - (*net/http.Server).ServeTLS
-    - (*net/http.Server).Shutdown
-    - os.Chdir
-    - os.Mkdir
-    - os.MkdirAll
-    - os.Remove
-    - os.RemoveAll
-    - os.Setenv
-    - os.Unsetenv
-    - (*os.File).WriteString
-    - (*os.File).Close
-    - (github.com/datarhei/gosrt.Conn).Close
-    - (github.com/datarhei/gosrt.Conn).SetReadDeadline
-    - (github.com/datarhei/gosrt.Conn).SetWriteDeadline
-    - (*github.com/bluenviron/gortsplib/v4.Client).Close
-    - (*github.com/bluenviron/gortsplib/v4.Server).Close
-    - (*github.com/bluenviron/gortsplib/v4.ServerSession).Close
-    - (*github.com/bluenviron/gortsplib/v4.ServerStream).Close
-    - (*github.com/bluenviron/gortsplib/v4.ServerConn).Close
+    govet:
+      enable-all: true
+      disable:
+      - fieldalignment
+      - reflectvaluecompare
 
-  govet:
-    enable-all: true
-    disable:
-    - fieldalignment
-    - reflectvaluecompare
+formatters:
+  enable:
+  - gofmt
+  - gofumpt
+  - goimports
diff --git a/Makefile b/Makefile
@@ -1,5 +1,5 @@
 BASE_IMAGE = golang:1.24-alpine3.20
-LINT_IMAGE = golangci/golangci-lint:v1.64.5
+LINT_IMAGE = golangci/golangci-lint:v2.1.6
 
 .PHONY: $(shell ls)
 
diff --git a/action_client.go b/action_client.go
@@ -389,19 +389,19 @@ type ActionClient struct {
 // NewActionClient allocates an ActionClient. See ActionClientConf for the options.
 func NewActionClient(conf ActionClientConf) (*ActionClient, error) {
 	if conf.Node == nil {
-		return nil, fmt.Errorf("Node is empty")
+		return nil, fmt.Errorf("'Node' is empty")
 	}
 
 	if conf.Name == "" {
-		return nil, fmt.Errorf("Name is empty")
+		return nil, fmt.Errorf("'Name' is empty")
 	}
 
 	if conf.Action == nil {
-		return nil, fmt.Errorf("Action is empty")
+		return nil, fmt.Errorf("'Action' is empty")
 	}
 
 	if reflect.TypeOf(conf.Action).Kind() != reflect.Ptr {
-		return nil, fmt.Errorf("Action is not a pointer")
+		return nil, fmt.Errorf("'Action' is not a pointer")
 	}
 
 	actionElem := reflect.ValueOf(conf.Action).Elem().Interface()
@@ -587,10 +587,10 @@ func (ac *ActionClient) WaitForServer() {
 // SendGoal sends a goal.
 func (ac *ActionClient) SendGoal(conf ActionClientGoalConf) (*ActionClientGoalHandler, error) {
 	if conf.Goal == nil {
-		return nil, fmt.Errorf("Goal is empty")
+		return nil, fmt.Errorf("'Goal' is empty")
 	}
 	if reflect.TypeOf(conf.Goal) != reflect.PointerTo(ac.goalType) {
-		return nil, fmt.Errorf("Goal must be %s, while is %v",
+		return nil, fmt.Errorf("'Goal' must be %s, while is %v",
 			reflect.PointerTo(ac.goalType), reflect.TypeOf(conf.Goal))
 	}
 
diff --git a/action_server.go b/action_server.go
@@ -248,19 +248,19 @@ type ActionServer struct {
 // NewActionServer allocates an ActionServer. See ActionServerConf for the options.
 func NewActionServer(conf ActionServerConf) (*ActionServer, error) {
 	if conf.Node == nil {
-		return nil, fmt.Errorf("Node is empty")
+		return nil, fmt.Errorf("'Node' is empty")
 	}
 
 	if conf.Name == "" {
-		return nil, fmt.Errorf("Name is empty")
+		return nil, fmt.Errorf("'Name' is empty")
 	}
 
 	if conf.Action == nil {
-		return nil, fmt.Errorf("Action is empty")
+		return nil, fmt.Errorf("'Action' is empty")
 	}
 
 	if reflect.TypeOf(conf.Action).Kind() != reflect.Ptr {
-		return nil, fmt.Errorf("Action is not a pointer")
+		return nil, fmt.Errorf("'Action' is not a pointer")
 	}
 
 	if conf.StatusPeriod == 0 {
diff --git a/examples/cluster-info/main.go b/examples/cluster-info/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
diff --git a/examples/param-set-get/main.go b/examples/param-set-get/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
diff --git a/examples/publisher-custom/main.go b/examples/publisher-custom/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
@@ -10,9 +11,8 @@ import (
 	"github.com/bluenviron/goroslib/v2/pkg/msg"
 )
 
-// define a custom message.
+// TestMessage is a custom message.
 // unlike the standard library, a .msg file is not needed.
-// a structure definition is enough.
 type TestMessage struct {
 	msg.Package `ros:"my_package"`
 	FirstField  uint32
diff --git a/examples/publisher/main.go b/examples/publisher/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
diff --git a/examples/serviceclient/main.go b/examples/serviceclient/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
@@ -10,16 +11,16 @@ import (
 // define a custom service.
 // unlike the standard library, a .srv file is not needed.
 
-type TestServiceReq struct {
+type TestServiceReq struct { //nolint:revive
 	A float64
 	B string
 }
 
-type TestServiceRes struct {
+type TestServiceRes struct { //nolint:revive
 	C float64
 }
 
-type TestService struct {
+type TestService struct { //nolint:revive
 	msg.Package `ros:"my_package"`
 	TestServiceReq
 	TestServiceRes
diff --git a/examples/serviceprovider/main.go b/examples/serviceprovider/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
@@ -12,16 +13,16 @@ import (
 // define a custom service.
 // unlike the standard library, a .srv file is not needed.
 
-type TestServiceReq struct {
+type TestServiceReq struct { //nolint:revive
 	A float64
 	B string
 }
 
-type TestServiceRes struct {
+type TestServiceRes struct { //nolint:revive
 	C float64
 }
 
-type TestService struct {
+type TestService struct { //nolint:revive
 	msg.Package `ros:"my_package"`
 	TestServiceReq
 	TestServiceRes
diff --git a/examples/simpleactionclient/main.go b/examples/simpleactionclient/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
@@ -12,19 +13,19 @@ import (
 // define a custom action.
 // unlike the standard library, an .action file is not needed.
 
-type DoSomethingActionGoal struct {
+type DoSomethingActionGoal struct { //nolint:revive
 	Input uint32
 }
 
-type DoSomethingActionResult struct {
+type DoSomethingActionResult struct { //nolint:revive
 	Output uint32
 }
 
-type DoSomethingActionFeedback struct {
+type DoSomethingActionFeedback struct { //nolint:revive
 	PercentComplete float32
 }
 
-type DoSomethingAction struct {
+type DoSomethingAction struct { //nolint:revive
 	msg.Package `ros:"shared_actions"`
 	DoSomethingActionGoal
 	DoSomethingActionResult
@@ -64,7 +65,7 @@ func main() {
 		Goal: &DoSomethingActionGoal{
 			Input: 1234312,
 		},
-		OnDone: func(state goroslib.SimpleActionClientGoalState, res *DoSomethingActionResult) {
+		OnDone: func(_ goroslib.SimpleActionClientGoalState, res *DoSomethingActionResult) {
 			log.Println("result:", res)
 			close(done)
 		},
diff --git a/examples/simpleactionserver/main.go b/examples/simpleactionserver/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
@@ -12,19 +13,19 @@ import (
 // define a custom action.
 // unlike the standard library, an .action file is not needed.
 
-type DoSomethingActionGoal struct {
+type DoSomethingActionGoal struct { //nolint:revive
 	Input uint32
 }
 
-type DoSomethingActionResult struct {
+type DoSomethingActionResult struct { //nolint:revive
 	Output uint32
 }
 
-type DoSomethingActionFeedback struct {
+type DoSomethingActionFeedback struct { //nolint:revive
 	PercentComplete float32
 }
 
-type DoSomethingAction struct {
+type DoSomethingAction struct { //nolint:revive
 	msg.Package `ros:"shared_actions"`
 	DoSomethingActionGoal
 	DoSomethingActionResult
@@ -48,7 +49,7 @@ func main() {
 		Node:   n,
 		Name:   "test_action",
 		Action: &DoSomethingAction{},
-		OnExecute: func(sas *goroslib.SimpleActionServer, goal *DoSomethingActionGoal) {
+		OnExecute: func(sas *goroslib.SimpleActionServer, _ *DoSomethingActionGoal) {
 			// publish a feedback
 			sas.PublishFeedback(&DoSomethingActionFeedback{
 				PercentComplete: 0.5,
diff --git a/examples/subscriber-custom/main.go b/examples/subscriber-custom/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
@@ -9,9 +10,8 @@ import (
 	"github.com/bluenviron/goroslib/v2/pkg/msg"
 )
 
-// define a custom message.
+// TestMessage is a custom message.
 // unlike the standard library, a .msg file is not needed.
-// a structure definition is enough.
 type TestMessage struct {
 	msg.Package `ros:"my_package"`
 	FirstField  uint32
diff --git a/examples/subscriber-ipv6/main.go b/examples/subscriber-ipv6/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
diff --git a/examples/subscriber-udp/main.go b/examples/subscriber-udp/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
diff --git a/examples/subscriber/main.go b/examples/subscriber/main.go
@@ -1,3 +1,4 @@
+// Package main contains an example.
 package main
 
 import (
diff --git a/node.go b/node.go
diff --git a/pkg/conversion/package.go b/pkg/conversion/package.go
diff --git a/pkg/protocommon/message.go b/pkg/protocommon/message.go
diff --git a/publisher.go b/publisher.go
diff --git a/service_client.go b/service_client.go
diff --git a/service_provider.go b/service_provider.go
diff --git a/simple_action_server.go b/simple_action_server.go
diff --git a/subscriber.go b/subscriber.go

Original file line number	Diff line number	Diff line change
`@@ -389,19 +389,19 @@ type ActionClient struct {`
`389`	`389`	`// NewActionClient allocates an ActionClient. See ActionClientConf for the options.`
`390`	`390`	`func NewActionClient(conf ActionClientConf) (*ActionClient, error) {`
`391`	`391`	`if conf.Node == nil {`
`392`		`- return nil, fmt.Errorf("Node is empty")`
	`392`	`+ return nil, fmt.Errorf("'Node' is empty")`
`393`	`393`	`}`
`394`	`394`
`395`	`395`	`if conf.Name == "" {`
`396`		`- return nil, fmt.Errorf("Name is empty")`
	`396`	`+ return nil, fmt.Errorf("'Name' is empty")`
`397`	`397`	`}`
`398`	`398`
`399`	`399`	`if conf.Action == nil {`
`400`		`- return nil, fmt.Errorf("Action is empty")`
	`400`	`+ return nil, fmt.Errorf("'Action' is empty")`
`401`	`401`	`}`
`402`	`402`
`403`	`403`	`if reflect.TypeOf(conf.Action).Kind() != reflect.Ptr {`
`404`		`- return nil, fmt.Errorf("Action is not a pointer")`
	`404`	`+ return nil, fmt.Errorf("'Action' is not a pointer")`
`405`	`405`	`}`
`406`	`406`
`407`	`407`	`actionElem := reflect.ValueOf(conf.Action).Elem().Interface()`
`@@ -587,10 +587,10 @@ func (ac *ActionClient) WaitForServer() {`
`587`	`587`	`// SendGoal sends a goal.`
`588`	`588`	`func (ac ActionClient) SendGoal(conf ActionClientGoalConf) (ActionClientGoalHandler, error) {`
`589`	`589`	`if conf.Goal == nil {`
`590`		`- return nil, fmt.Errorf("Goal is empty")`
	`590`	`+ return nil, fmt.Errorf("'Goal' is empty")`
`591`	`591`	`}`
`592`	`592`	`if reflect.TypeOf(conf.Goal) != reflect.PointerTo(ac.goalType) {`
`593`		`- return nil, fmt.Errorf("Goal must be %s, while is %v",`
	`593`	`+ return nil, fmt.Errorf("'Goal' must be %s, while is %v",`
`594`	`594`	`reflect.PointerTo(ac.goalType), reflect.TypeOf(conf.Goal))`
`595`	`595`	`}`
`596`	`596`
Original file line number	Diff line number	Diff line change
`@@ -248,19 +248,19 @@ type ActionServer struct {`
`248`	`248`	`// NewActionServer allocates an ActionServer. See ActionServerConf for the options.`
`249`	`249`	`func NewActionServer(conf ActionServerConf) (*ActionServer, error) {`
`250`	`250`	`if conf.Node == nil {`
`251`		`- return nil, fmt.Errorf("Node is empty")`
	`251`	`+ return nil, fmt.Errorf("'Node' is empty")`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`if conf.Name == "" {`
`255`		`- return nil, fmt.Errorf("Name is empty")`
	`255`	`+ return nil, fmt.Errorf("'Name' is empty")`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`if conf.Action == nil {`
`259`		`- return nil, fmt.Errorf("Action is empty")`
	`259`	`+ return nil, fmt.Errorf("'Action' is empty")`
`260`	`260`	`}`
`261`	`261`
`262`	`262`	`if reflect.TypeOf(conf.Action).Kind() != reflect.Ptr {`
`263`		`- return nil, fmt.Errorf("Action is not a pointer")`
	`263`	`+ return nil, fmt.Errorf("'Action' is not a pointer")`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`if conf.StatusPeriod == 0 {`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// Package main contains an example.`
`1`	`2`	`package main`
`2`	`3`
`3`	`4`	`import (`