hard code sort min node version

Author: claytercek

.changeset/old-baboons-move.md

@@ -0,0 +1,5 @@
+---
+"@bluecadet/launchpad-monitor": patch
+---
+
+Hard code window reorder MIN_NODE_VERSION instead of making it configurable

packages/monitor/src/core/__tests__/app-manager.test.ts

@@ -47,7 +47,6 @@ function setupTestAppManager() {
 		],
 		windowsApi: {
 			debounceDelay: 3000,
-			nodeVersion: ">=17.4.0",
 		},
 		deleteExistingBeforeConnect: false,
 		plugins: [],

packages/monitor/src/core/app-manager.ts

@@ -104,7 +104,7 @@ export class AppManager {
 
 		return ResultAsync.combine(appResults).andThen((apps) => {
 			return ResultAsync.fromPromise(
-				sortWindows(apps, this.#logger, this.#config.windowsApi.nodeVersion),
+				sortWindows(apps, this.#logger),
 				(e) => new Error("Failed to sort windows", { cause: e }),
 			);
 		});

packages/monitor/src/monitor-config.ts

@@ -14,16 +14,6 @@ const windowsApiConfigSchema = z.object({
 		.describe(
 			"The delay until windows are ordered after launch of in ms. Defaults to 3000. If your app takes a long time to open all of its windows, set this number to a higher value to ensure it can be on top of the launchpad terminal window. Keeping this high also reduces the CPU load if apps relaunch often.",
 		),
-	/**
-	 * The minimum major node version to support window ordering. Node versions < 17 seem to have a fatal
-	 * bug with the native API, which will intermittently cause V8 to crash hard. Defaults to '>=17.4.0'.
-	 */
-	nodeVersion: z
-		.string()
-		.default(">=17.4.0")
-		.describe(
-			"The minimum major node version to support window ordering. Node versions < 17 seem to have a fatal bug with the native API, which will intermittently cause V8 to crash hard. Defaults to '>=17.4.0'.",
-		),
 });
 
 export type WindowsApiConfig = z.infer<typeof windowsApiConfigSchema>;

packages/monitor/src/utils/__tests__/sort-windows.test.ts

@@ -1,11 +1,10 @@
 import { afterEach } from "node:test";
 import { createMockLogger } from "@bluecadet/launchpad-testing/test-utils.ts";
 import type { Logger } from "@bluecadet/launchpad-utils";
-import chalk from "chalk";
 import { type Window, windowManager } from "node-window-manager";
 import semver from "semver";
 import { beforeEach, describe, expect, it, vi } from "vitest";
-import sortWindows from "../sort-windows.js";
+import sortWindows, { MIN_NODE_VERSION } from "../sort-windows.js";
 
 // Mock node-window-manager
 vi.mock("node-window-manager", () => ({
@@ -46,11 +45,10 @@ describe("sortWindows", () => {
 	});
 
 	it("should check node version before proceeding", async () => {
-		const minNodeVersion = ">=18.0.0";
 		vi.spyOn(semver, "satisfies").mockReturnValueOnce(false);
 
-		await expect(sortWindows([], mockLogger, minNodeVersion)).rejects.toThrow(/Can't sort windows/);
-		expect(semver.satisfies).toHaveBeenCalledWith(process.version, minNodeVersion);
+		await expect(sortWindows([], mockLogger)).rejects.toThrow(/Can't sort windows/);
+		expect(semver.satisfies).toHaveBeenCalledWith(process.version, MIN_NODE_VERSION);
 	});
 
 	it("should handle empty apps array", async () => {

packages/monitor/src/utils/sort-windows.ts

@@ -9,16 +9,21 @@ type SortApp = {
 	pid?: number;
 };
 
+/**
+ * The minimum major node version to support window ordering. Node versions < 17 seem to have a fatal
+ * bug with the native API, which will intermittently cause V8 to crash hard. Defaults to '>=17.4.0'.
+ */
+export const MIN_NODE_VERSION = ">=17.4.0";
+
 const sortWindows = async (
 	apps: SortApp[],
-	logger: Logger,
-	minNodeVersion?: string,
+	logger: Logger
 ): Promise<void> => {
 	const currNodeVersion = process.version;
-	if (minNodeVersion && !semver.satisfies(currNodeVersion, minNodeVersion)) {
+	if (!semver.satisfies(currNodeVersion, MIN_NODE_VERSION)) {
 		return Promise.reject(
 			new Error(
-				`Can't sort windows because the current node version '${currNodeVersion}' doesn't satisfy the required version '${minNodeVersion}'. Please upgrade node to apply window settings like foreground/minimize/hide.`,
+				`Can't sort windows because the current node version '${currNodeVersion}' doesn't satisfy the required version '${MIN_NODE_VERSION}'. Please upgrade node to apply window settings like foreground/minimize/hide.`,
 			),
 		);
 	}