Merge pull request #95 from igierard/bugfix/pwsh7

Refactors Disable-Service to use CIM commands

Author: benjaminbojko

packages/scaffold/scripts/functions.psm1

@@ -123,17 +123,17 @@ function Disable-Service(
         [String]$ComputerName = "$(hostname)"
     ) {
     # See https://social.technet.microsoft.com/Forums/lync/en-US/abde2699-0d5a-49ad-bfda-e87d903dd865/disable-windows-update-via-powershell?forum=winserverpowershell
-    $service = Get-WmiObject Win32_Service -Filter "Name='$ServiceName'" -ComputerName $ComputerName -Ea 0;
+    $service = Get-CimInstance win32_service -Filter "Name='$ServiceName'" -Ea 0;
     if ($service) {
         if ($service.StartMode -ne "Disabled") {
-            $result = $service.ChangeStartMode("Disabled").ReturnValue;
+            $result = (Invoke-CimMethod -InputObject $service -methodname ChangeStartmode -Arguments @{startmode='Disabled'}).ReturnValue;
             if ($result) {
                 Write-Host "Failed to disable the '$ServiceName' service on $ComputerName. The return value was $result." -ForegroundColor Red;
             } else {
                 Write-Host "Successfully disabled the '$ServiceName' service on $ComputerName." -ForegroundColor Green;
             }
             if ($service.State -eq "Running") {
-                $result = $service.StopService().ReturnValue;
+                $result = (Invoke-CimMethod -InputObject $service -methodname StopService).ReturnValue.ReturnValue;
                 if ($result) {
                     Write-Host "Failed to stop the '$ServiceName' service on $ComputerName. The return value was $result." -ForegroundColor Red;
                 } else {

packages/scaffold/scripts/windows/disable_update_service.ps1

@@ -6,8 +6,19 @@ try {
 }
 
 Write-Output "Disabling Windows Update Medic Service"
+# Windows Update Medic Service can only be disabled via the registry
 Set-ItemProperty -Path 'HKLM:\SYSTEM\CurrentControlSet\Services\WaaSMedicSvc' -Name 'Start' -value 4
-Disable-Service("WaaSMedicSVC");
+Write-Host "Successfully disabled the 'WaaSMedicSVC' service on $ComputerName." -ForegroundColor Green;
+$WaaSMedicSVC = get-ciminstance win32_service -Filter "Name='WaaSMedicSVC'" -Ea 0;
+if($WaaSMedicSVC.State -eq "Running"){
+    $ComputerName = "$(hostname)"
+    $result = (Invoke-CimMethod -InputObject $WaaSMedicSVC -methodname StopService).ReturnValue
+    if ($result) {
+        Write-Host "Failed to stop the 'WaaSMedicSVC' service on $ComputerName. The return value was $result." -ForegroundColor Red;
+    } else {
+        Write-Host "Successfully stopped the 'WaaSMedicSVC' service on $ComputerName." -ForegroundColor Green;
+    }
+}
 
 Write-Output "Disabling Update Orchestrator Service"
 Disable-Service("UsoSvc");

packages/scaffold/scripts/windows/enable_script_execution.ps1

@@ -6,5 +6,3 @@ force-mkdir "HKLM:\SOFTWARE\Policies\Microsoft\Windows"
 
 Set-ItemProperty -Path "HKLM:\SOFTWARE\Policies\Microsoft\Windows" -Name "EnableScripts" -Type DWord -Value 1
 Set-ItemProperty -Path "HKLM:\SOFTWARE\Microsoft\PowerShell\1\ShellIds\Microsoft.PowerShell" -Name "ExecutionPolicy" -Type String -Value "RemoteSigned"
-
-HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Windows