Allow for changing responsive reading of Psalms by half verse and whole verse #150
Replies: 2 comments 2 replies
-
@blocher - I realized that the "Psalm Recitation Style" is listed as an "Advanced Setting", so it's already there in the full Morning and Evening Prayer. My bad. Also, I see that when set in settings, it also updates it on the daily readings too, which is exactly what I was looking for. I guess the only thing is that I didn't realize that there even were advanced settings until I dug into the code a bit. I overlooked the "Frequently Used / All Settings" toggle on the bottom of the settings page. I wonder if there is a way to make the advanced settings more visible, as they might be overlooked unless you know to switch the toggle? |
Beta Was this translation helpful? Give feedback.
-
@blocher - Good news. I have worked the "Psalm Recitation Style" into the Readings section, using an HTML select like the "Translation" and "Psalter Version". Once you approve PR #148, I will submit another PR for this addition. It functions identically to the other HTML selects, including saving in local storage. It does lengthen that section a bit, but it does look good on mobile. Thanks! ![]() |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
@blocher I'd like to add the ability to change the "Psalm Recitation Style" both for Morning and Evening Prayer as well as the "Day's Readings". Since the API calls for MP/EP are based on settings, it'd be fairly easy to add "Psalm Recitation Style" as a setting. From what I can see, there would be no other changes required to the Vue templates.
As for the "Day's Readings", which isn't based on stored settings at all, I think I'd suggest one of two approaches:
whole_verse
andhalf_verse
to thereadings
API response. The API response would be much larger (as you'd need 4 variations: "whole 30", "whole 60", "half 30", and "half 60"), but that may not be too big of a deal. We could then add a toggle switch (similar to the 30 Day Cycle / 60 Day Cycle) to toggle between these.psalm_style=plain
(in addition to the existingwhole_verse
,half_verse
, andunison
). This would not return verses with<strong>
tags but would return somewhat "plain" text, and the Vue frontend would add the relevant tags or font-weight based on the status of the toggle switch.I used to be more favorable to option 2, but the more I think about it, I am leaning towards option 1. But I wanted to open this up for discussion to get your thoughts. I welcome your feedback. Let me know if I have misunderstood anything.
Beta Was this translation helpful? Give feedback.
All reactions