Add test for GitHub call

Author: bram-pkg

composer.json

@@ -25,6 +25,7 @@
   "require": {
     "php": "^8.0",
     "composer/semver": "^3.3",
+    "guzzlehttp/guzzle": "^7.5",
     "illuminate/contracts": "^9.0 | ^10.0",
     "twig/twig": "^3.0"
   },

src/Integrations/SupportedPhpExtensions.php

@@ -2,6 +2,9 @@
 
 namespace BlameButton\LaravelDockerBuilder\Integrations;
 
+use Illuminate\Support\Facades\Http;
+use function Symfony\Component\String\b;
+
 class SupportedPhpExtensions
 {
     private const URL = 'https://github.com/mlocati/docker-php-extension-installer/raw/master/data/supported-extensions';
@@ -10,7 +13,7 @@ class SupportedPhpExtensions
 
     public function get(string $phpVersion = null): array
     {
-        if (! is_null($this->cache)) {
+        if (!is_null($this->cache)) {
             return $this->cache;
         }
 
@@ -21,18 +24,24 @@ public function get(string $phpVersion = null): array
         }
 
         return $this->cache = collect($contents)
-            ->filter(fn (string $extension): bool => is_null($phpVersion) || str($extension)->contains($phpVersion))
-            ->map(fn (string $extension): string => str($extension)->trim()->before(' '))
+            ->filter(fn(string $extension): bool => is_null($phpVersion) || str($extension)->contains($phpVersion))
+            ->map(fn(string $extension): string => str($extension)->trim()->before(' '))
             ->filter()
             ->values()
             ->toArray();
     }
 
-    /**
-     * @codeCoverageIgnore this fetches an actual file from GitHub
-     */
-    protected function fetch(): array|false
+    public function fetch(): array|false
     {
-        return file(self::URL);
+        $response = rescue(
+            callback: fn() => Http::get(self::URL),
+            rescue: false,
+        );
+
+        if ($response === false || $response->failed()) {
+            return false;
+        }
+
+        return array_filter(explode("\n", $response->body()));
     }
 }

tests/Unit/Integrations/SupportedPhpExtensionsTest.php

@@ -4,6 +4,7 @@
 
 use BlameButton\LaravelDockerBuilder\Integrations\SupportedPhpExtensions;
 use BlameButton\LaravelDockerBuilder\Tests\TestCase;
+use Illuminate\Support\Facades\Http;
 use Mockery\MockInterface;
 
 /**
@@ -72,4 +73,36 @@ public function testItCachesResponse(): void
         app(SupportedPhpExtensions::class)->get();
         app(SupportedPhpExtensions::class)->get();
     }
+
+    public function testItReturnsFalseOnError(): void
+    {
+        Http::fake([
+            'github.com/*' => Http::response("bcmath\nmemcached", 500),
+        ]);
+
+        $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) {
+            $mock->shouldAllowMockingProtectedMethods();
+            $mock->shouldReceive('fetch')->once()->passthru();
+        });
+
+        $response = app(SupportedPhpExtensions::class)->fetch();
+
+        self::assertFalse($response);
+    }
+
+    public function testItReturnsExtensions(): void
+    {
+        Http::fake([
+            'github.com/*' => Http::response("bcmath\nmemcached\n"),
+        ]);
+
+        $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) {
+            $mock->shouldAllowMockingProtectedMethods();
+            $mock->shouldReceive('fetch')->once()->passthru();
+        });
+
+        $response = app(SupportedPhpExtensions::class)->fetch();
+
+        self::assertEquals(['bcmath', 'memcached'], $response);
+    }
 }