Add test for SupportedPhpExtensions

Author: bram-pkg

src/Commands/GenerateQuestions/Choices/PhpExtensions.php

@@ -8,6 +8,6 @@ class PhpExtensions
 {
     public static function values(string $phpVersion = null): array
     {
-        return app(SupportedPhpExtensions::class)->fetch($phpVersion);
+        return app(SupportedPhpExtensions::class)->get($phpVersion);
     }
 }

src/Integrations/SupportedPhpExtensions.php

@@ -8,14 +8,14 @@ class SupportedPhpExtensions
 
     private array|null $cache = null;
 
-    public function fetch(string $phpVersion = null): array
+    public function get(string $phpVersion = null): array
     {
         if (! is_null($this->cache)) {
             return $this->cache;
         }
 
         try {
-            $contents = file_get_contents(self::URL);
+            $contents = $this->fetch();
 
             return $this->cache = str($contents)
                 ->explode("\n")
@@ -27,4 +27,9 @@ public function fetch(string $phpVersion = null): array
             return [];
         }
     }
+
+    protected function fetch(): string|false
+    {
+        return file_get_contents(self::URL);
+    }
 }

tests/Feature/Commands/DockerGenerateCommandTest.php

@@ -27,7 +27,6 @@
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodeBuildTool
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\NodeBuildToolQuestion
  * @covers \BlameButton\LaravelDockerBuilder\Objects\Configuration
- *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\DockerGenerateCommand
  */
 class DockerGenerateCommandTest extends TestCase
@@ -39,29 +38,29 @@ public function provideCommands(): array
                 [
                     "FROM php:8.2-fpm-alpine AS composer\n",
                     "FROM node:lts-alpine AS node\n",
-                    "COPY /package.json /package-lock.json /app/",
+                    'COPY /package.json /package-lock.json /app/',
                     "COPY /vite.config.js /app/\n",
                     "RUN npm run build\n",
                     "RUN install-php-extensions bcmath pdo_pgsql redis\n",
                     "COPY --from=node /app/public/build/ /app/public/build/\n",
-                    "RUN echo \"php artisan optimize --no-ansi && php-fpm\" >> /usr/bin/entrypoint.sh",
-                    "CMD [\"/usr/bin/entrypoint.sh\"]\n"
+                    'RUN echo "php artisan optimize --no-ansi && php-fpm" >> /usr/bin/entrypoint.sh',
+                    "CMD [\"/usr/bin/entrypoint.sh\"]\n",
                 ],
                 'docker:generate -n -p 8.2 -e bcmath,pdo_pgsql,redis -o -a -m npm -b vite',
             ],
             '8.1, mysql, apcu, no optimize, no alpine, yarn, mix' => [
                 [
                     "FROM php:8.1-fpm AS composer\n",
                     "FROM node:lts AS node\n",
-                    "COPY /package.json /yarn.lock /app/",
+                    'COPY /package.json /yarn.lock /app/',
                     "COPY /webpack.mix.js /app/\n",
                     "RUN yarn run production\n",
                     "RUN install-php-extensions bcmath pdo_mysql apcu\n",
                     "COPY --from=node /app/public/css/ /app/public/css/\n",
                     "COPY --from=node /app/public/js/ /app/public/js/\n",
                     "COPY --from=node /app/public/fonts/ /app/public/fonts/\n",
-                    "RUN echo \"php-fpm\" >> /usr/bin/entrypoint.sh",
-                    "CMD [\"/usr/bin/entrypoint.sh\"]\n"
+                    'RUN echo "php-fpm" >> /usr/bin/entrypoint.sh',
+                    "CMD [\"/usr/bin/entrypoint.sh\"]\n",
                 ],
                 'docker:generate -n -p 8.1 -e bcmath,pdo_mysql,apcu --no-optimize --no-alpine -m yarn -b mix',
             ],
@@ -72,7 +71,7 @@ public function provideCommands(): array
     public function testItGeneratesConfigurations(array $expected, string $command): void
     {
         $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) {
-            $mock->shouldReceive('fetch')->withAnyArgs()->andReturn([
+            $mock->shouldReceive('get')->withAnyArgs()->andReturn([
                 'bcmath', 'pdo_mysql', 'pdo_pgsql', 'redis', 'apcu',
             ]);
         });
@@ -89,8 +88,8 @@ public function testItGeneratesConfigurations(array $expected, string $command):
     public function testItAsksQuestions(): void
     {
         $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) {
-            $mock->shouldReceive('fetch')->with('8.2')->once()->andReturn(['bcmath', 'redis']);
-            $mock->shouldReceive('fetch')->with(null)->andReturn(['not the same as with 8.2']);
+            $mock->shouldReceive('get')->with('8.2')->once()->andReturn(['bcmath', 'redis']);
+            $mock->shouldReceive('get')->with(null)->andReturn(['not the same as with 8.2']);
         });
 
         $command = $this->artisan('docker:generate');

tests/Unit/Commands/GenerateQuestions/Choices/PhpExtensionsTest.php

@@ -17,7 +17,7 @@ class PhpExtensionsTest extends TestCase
     public function testItCallsSupportedPhpExtensions(): void
     {
         $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) {
-            $mock->shouldReceive('fetch')->once()->andReturn([
+            $mock->shouldReceive('get')->once()->andReturn([
                 'bcmath',
                 'pdo_mysql',
                 'redis',

tests/Unit/Integrations/SupportedPhpExtensionsTest.php

@@ -0,0 +1,53 @@
+<?php
+
+namespace BlameButton\LaravelDockerBuilder\Tests\Unit\Integrations;
+
+use BlameButton\LaravelDockerBuilder\Integrations\SupportedPhpExtensions;
+use BlameButton\LaravelDockerBuilder\Tests\TestCase;
+use Mockery\MockInterface;
+
+/**
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ *
+ * @covers \BlameButton\LaravelDockerBuilder\Integrations\SupportedPhpExtensions
+ */
+class SupportedPhpExtensionsTest extends TestCase
+{
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->partialMock(SupportedPhpExtensions::class, function (MockInterface $mock) {
+            $mock->shouldAllowMockingProtectedMethods();
+            $mock->shouldReceive('get')
+                ->once()
+                ->passthru();
+            $mock->shouldReceive('fetch')
+                ->once()
+                ->andReturn(<<<'RES'
+                    apcu 8.1 8.2
+                    pdo_mysql 8.2
+                    pdo_pgsql 8.0 8.1
+                    memcached 8.0
+                    redis 8.1
+                RES);
+        });
+    }
+
+    public function providePhpVersions(): array
+    {
+        return [
+            [['apcu', 'pdo_mysql'], '8.2'],
+            [['apcu', 'pdo_pgsql', 'redis'], '8.1'],
+            [['pdo_pgsql', 'memcached'], '8.0'],
+        ];
+    }
+
+    /** @dataProvider providePhpVersions */
+    public function testItFiltersVersions(): void
+    {
+        $supported = app(SupportedPhpExtensions::class)->get('8.2');
+
+        self::assertEquals(['apcu', 'pdo_mysql'], $supported);
+    }
+}