Add PhpExtensionsQuestion test

bram-pkg · bram-pkg · commit 48e71c7c0d3e · 2023-01-15T19:01:36.000Z
diff --git a/phpunit.xml b/phpunit.xml
@@ -22,7 +22,7 @@
 
         <report>
             <html outputDirectory=".coverage"/>
-            <text outputFile="php://stdout"/>
+            <text outputFile="php://stdout" showOnlySummary="true"/>
         </report>
     </coverage>
 </phpunit>
diff --git a/src/Commands/GenerateQuestions/PhpExtensionsQuestion.php b/src/Commands/GenerateQuestions/PhpExtensionsQuestion.php
@@ -21,37 +21,39 @@ class PhpExtensionsQuestion extends BaseQuestion
      */
     public function getAnswer(BaseCommand $command, string $phpVersion): array
     {
-        $supportedExtensions = PhpExtensions::values($phpVersion);
+        $supported = PhpExtensions::values($phpVersion);
 
         if ($option = $command->option('php-extensions')) {
             $extensions = explode(',', $option);
 
             foreach ($extensions as $extension) {
-                if (in_array($extension, $supportedExtensions)) {
+                if (in_array($extension, $supported)) {
                     continue;
                 }
 
                 throw new InvalidOptionValueException("Extension [$extension] is not supported.");
             }
 
-            return array_intersect($extensions, $supportedExtensions);
+            return array_intersect($extensions, $supported);
         }
 
-        $detected = app(PhpExtensionsDetector::class, ['supportedExtensions' => $supportedExtensions])->detect();
+        $detected = app(PhpExtensionsDetector::class)
+            ->supported($supported)
+            ->detect();
 
         if ($command->option('detect')) {
             $detected = explode(',', $detected);
 
             foreach ($detected as $key => $value) {
-                $detected[$key] = $supportedExtensions[$value];
+                $detected[$key] = $supported[$value];
             }
 
             return $detected;
         }
 
         return $command->choice(
             question: 'PHP extensions',
-            choices: $supportedExtensions,
+            choices: $supported,
             default: $detected,
             multiple: true,
         );
diff --git a/src/Detector/PhpExtensionsDetector.php b/src/Detector/PhpExtensionsDetector.php
@@ -7,11 +7,17 @@
 
 class PhpExtensionsDetector implements DetectorContract
 {
-    /**
-     * @param  string[]  $supportedExtensions
-     */
-    public function __construct(private array $supportedExtensions)
+    private array $supported;
+
+    public function supported(array $supported = null): self|array
     {
+        if (is_null($supported)) {
+            return $this->supported;
+        }
+
+        $this->supported = $supported;
+
+        return $this;
     }
 
     public function detect(): string|false
@@ -29,9 +35,9 @@ public function detect(): string|false
             ->flatten()
             ->unique()
             ->sort()
-            ->intersect($this->supportedExtensions)
-            ->map(fn (string $extension) => array_search($extension, $this->supportedExtensions))
-            ->filter()
+            ->intersect($this->supported())
+            ->map(fn (string $extension) => array_search($extension, $this->supported()))
+            ->filter(fn ($value) => is_int($value))
             ->join(',');
     }
 
diff --git a/src/DockerServiceProvider.php b/src/DockerServiceProvider.php
@@ -6,10 +6,16 @@
 use BlameButton\LaravelDockerBuilder\Commands\DockerCiCommand;
 use BlameButton\LaravelDockerBuilder\Commands\DockerGenerateCommand;
 use BlameButton\LaravelDockerBuilder\Commands\DockerPushCommand;
+use BlameButton\LaravelDockerBuilder\Integrations\SupportedPhpExtensions;
 use Illuminate\Support\ServiceProvider;
 
 class DockerServiceProvider extends ServiceProvider
 {
+    public function register(): void
+    {
+        $this->app->singleton(SupportedPhpExtensions::class);
+    }
+
     public function boot(): void
     {
         if ($this->app->runningInConsole()) {
diff --git a/tests/Feature/Commands/DockerGenerateCommandTest.php b/tests/Feature/Commands/DockerGenerateCommandTest.php
@@ -7,25 +7,25 @@
 use Mockery\MockInterface;
 
 /**
- * @uses   \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ * @uses   \BlameButton\LaravelDockerBuilder\DockerServiceProvider
  * @uses   \BlameButton\LaravelDockerBuilder\Detector\FileDetector
  * @uses   \BlameButton\LaravelDockerBuilder\Detector\PhpVersionDetector
  * @uses   \BlameButton\LaravelDockerBuilder\Detector\PhpExtensionsDetector
  * @uses   \BlameButton\LaravelDockerBuilder\Detector\NodePackageManagerDetector
  * @uses   \BlameButton\LaravelDockerBuilder\Detector\NodeBuildToolDetector
  * @uses   package_path()
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\BaseCommand::optionalChoice
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\PhpVersion
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\PhpVersionQuestion
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\PhpExtensions
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\PhpExtensionsQuestion
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\ArtisanOptimizeQuestion
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\AlpineQuestion
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodePackageManager
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\NodePackageManagerQuestion
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodeBuildTool
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\NodeBuildToolQuestion
  *
- * @covers \BlameButton\LaravelDockerBuilder\Commands\BaseCommand::optionalChoice
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\PhpVersion
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\PhpVersionQuestion
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\PhpExtensions
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\PhpExtensionsQuestion
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\ArtisanOptimizeQuestion
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\AlpineQuestion
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodePackageManager
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\NodePackageManagerQuestion
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodeBuildTool
- * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\NodeBuildToolQuestion
  * @covers \BlameButton\LaravelDockerBuilder\Objects\Configuration
  * @covers \BlameButton\LaravelDockerBuilder\Commands\DockerGenerateCommand
  */
diff --git a/tests/Unit/Commands/BaseDockerCommandTest.php b/tests/Unit/Commands/BaseDockerCommandTest.php
@@ -8,7 +8,7 @@
 use Symfony\Component\Process\Process;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\BaseDockerCommand
  */
diff --git a/tests/Unit/Commands/DockerBuildCommandTest.php b/tests/Unit/Commands/DockerBuildCommandTest.php
@@ -7,8 +7,8 @@
 use Symfony\Component\Process\Process;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
- * @uses   package_path()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
+ * @uses package_path()
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\DockerBuildCommand
  */
diff --git a/tests/Unit/Commands/DockerPushCommandTest.php b/tests/Unit/Commands/DockerPushCommandTest.php
@@ -7,8 +7,8 @@
 use Symfony\Component\Process\Process;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
- * @uses   package_path()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
+ * @uses package_path()
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\DockerPushCommand
  */
diff --git a/tests/Unit/Commands/GenerateQuestions/AlpineQuestionTest.php b/tests/Unit/Commands/GenerateQuestions/AlpineQuestionTest.php
@@ -7,7 +7,7 @@
 use BlameButton\LaravelDockerBuilder\Tests\TestCase;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\AlpineQuestion
  */
diff --git a/tests/Unit/Commands/GenerateQuestions/ArtisanOptimizeQuestionTest.php b/tests/Unit/Commands/GenerateQuestions/ArtisanOptimizeQuestionTest.php
@@ -7,7 +7,7 @@
 use BlameButton\LaravelDockerBuilder\Tests\TestCase;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\ArtisanOptimizeQuestion
  */
diff --git a/tests/Unit/Commands/GenerateQuestions/Choices/NodeBuildToolTest.php b/tests/Unit/Commands/GenerateQuestions/Choices/NodeBuildToolTest.php
@@ -6,7 +6,7 @@
 use BlameButton\LaravelDockerBuilder\Tests\TestCase;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodeBuildTool
  */
diff --git a/tests/Unit/Commands/GenerateQuestions/Choices/NodePackageManagerTest.php b/tests/Unit/Commands/GenerateQuestions/Choices/NodePackageManagerTest.php
@@ -6,7 +6,7 @@
 use BlameButton\LaravelDockerBuilder\Tests\TestCase;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodePackageManager
  */
diff --git a/tests/Unit/Commands/GenerateQuestions/Choices/PhpExtensionsTest.php b/tests/Unit/Commands/GenerateQuestions/Choices/PhpExtensionsTest.php
@@ -8,7 +8,7 @@
 use Mockery\MockInterface;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\PhpExtensions
  */
diff --git a/tests/Unit/Commands/GenerateQuestions/Choices/PhpVersionTest.php b/tests/Unit/Commands/GenerateQuestions/Choices/PhpVersionTest.php
@@ -6,7 +6,7 @@
 use BlameButton\LaravelDockerBuilder\Tests\TestCase;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\PhpVersion
  */
diff --git a/tests/Unit/Commands/GenerateQuestions/NodeBuildToolQuestionTest.php b/tests/Unit/Commands/GenerateQuestions/NodeBuildToolQuestionTest.php
@@ -11,8 +11,8 @@
 use Mockery\MockInterface;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
- * @uses   \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodeBuildTool
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodeBuildTool
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\NodeBuildToolQuestion
  */
diff --git a/tests/Unit/Commands/GenerateQuestions/NodePackageManagerQuestionTest.php b/tests/Unit/Commands/GenerateQuestions/NodePackageManagerQuestionTest.php
@@ -11,8 +11,8 @@
 use Mockery\MockInterface;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
- * @uses   \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodePackageManager
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
+ * @uses \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\NodePackageManager
  *
  * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\NodePackageManagerQuestion
  */
diff --git a/tests/Unit/Commands/GenerateQuestions/PhpExtensionsQuestionTest.php b/tests/Unit/Commands/GenerateQuestions/PhpExtensionsQuestionTest.php
@@ -2,6 +2,122 @@
 
 namespace BlameButton\LaravelDockerBuilder\Tests\Unit\Commands\GenerateQuestions;
 
-class PhpExtensionsQuestionTest
+use BlameButton\LaravelDockerBuilder\Commands\BaseCommand;
+use BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\PhpExtensionsQuestion;
+use BlameButton\LaravelDockerBuilder\Detector\PhpExtensionsDetector;
+use BlameButton\LaravelDockerBuilder\Exceptions\InvalidOptionValueException;
+use BlameButton\LaravelDockerBuilder\Integrations\SupportedPhpExtensions;
+use BlameButton\LaravelDockerBuilder\Tests\TestCase;
+use Mockery\MockInterface;
+
+/**
+ * @uses   \BlameButton\LaravelDockerBuilder\DockerServiceProvider
+ * @uses   \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\Choices\PhpExtensions
+ *
+ * @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\PhpExtensionsQuestion
+ */
+class PhpExtensionsQuestionTest extends TestCase
 {
+    public function testItValidatesOptionInput(): void
+    {
+        $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) {
+            $mock->shouldReceive('get')
+                ->with('8.2')
+                ->once()
+                ->andReturn(['bcmath', 'pdo_mysql']);
+        });
+
+        $mock = $this->createMock(BaseCommand::class);
+        $mock->expects($this->once())
+            ->method('option')
+            ->with('php-extensions')
+            ->willReturn('bcmath,pdo_mysql,redis');
+
+        $this->expectException(InvalidOptionValueException::class);
+        $this->expectExceptionMessage('Extension [redis] is not supported.');
+
+        app(PhpExtensionsQuestion::class)->getAnswer($mock, '8.2');
+    }
+
+    public function testItUsesOptionInput(): void
+    {
+        $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) {
+            $mock->shouldReceive('get')
+                ->with('8.2')
+                ->once()
+                ->andReturn(['bcmath', 'pdo_mysql', 'redis']);
+        });
+
+        $mock = $this->createMock(BaseCommand::class);
+        $mock->expects($this->once())
+            ->method('option')
+            ->with('php-extensions')
+            ->willReturn('bcmath,pdo_mysql');
+
+        $answer = app(PhpExtensionsQuestion::class)->getAnswer($mock, '8.2');
+
+        self::assertEquals(['bcmath', 'pdo_mysql'], $answer);
+    }
+
+    public function testItDetectsExtensions(): void
+    {
+        $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) {
+            $mock->shouldReceive('get')
+                ->once()
+                ->andReturn(['bcmath', 'pdo_mysql', 'redis']);
+        });
+
+        $this->partialMock(PhpExtensionsDetector::class, function (MockInterface $mock) {
+            $mock->shouldReceive('supported')
+                ->once()
+                ->andReturnSelf();
+            $mock->shouldReceive('detect')
+                ->once()
+                ->andReturn('0,1');
+        });
+
+        $mock = $this->createMock(BaseCommand::class);
+        $mock->expects($this->exactly(2))
+            ->method('option')
+            ->willReturnMap([
+                ['php-extensions', null],
+                ['detect', true],
+            ]);
+
+        $answer = app(PhpExtensionsQuestion::class)->getAnswer($mock, '8.2');
+
+        self::assertEquals(['bcmath', 'pdo_mysql'], $answer);
+    }
+    public function testItAsksForInput(): void
+    {
+        $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) {
+            $mock->shouldReceive('get')
+                ->once()
+                ->andReturn(['bcmath', 'pdo_mysql', 'redis']);
+        });
+
+        $this->partialMock(PhpExtensionsDetector::class, function (MockInterface $mock) {
+            $mock->shouldReceive('supported')
+                ->once()
+                ->andReturnSelf();
+            $mock->shouldReceive('detect')
+                ->once()
+                ->andReturn('');
+        });
+
+        $mock = $this->createMock(BaseCommand::class);
+        $mock->expects($this->exactly(2))
+            ->method('option')
+            ->willReturnMap([
+                ['php-extensions', null],
+                ['detect', null],
+            ]);
+        $mock->expects($this->once())
+            ->method('choice')
+            ->willReturn(['bcmath', 'pdo_mysql']);
+
+        $answer = app(PhpExtensionsQuestion::class)->getAnswer($mock, '8.2');
+
+        self::assertEquals(['bcmath', 'pdo_mysql'], $answer);
+    }
 }
diff --git a/tests/Unit/Integrations/SupportedPhpExtensionsTest.php b/tests/Unit/Integrations/SupportedPhpExtensionsTest.php
@@ -7,7 +7,7 @@
 use Mockery\MockInterface;
 
 /**
- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()
+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider
  *
  * @covers \BlameButton\LaravelDockerBuilder\Integrations\SupportedPhpExtensions
  */

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use Symfony\Component\Process\Process;`
`9`	`9`
`10`	`10`	`/**`
`11`		`- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()`
	`11`	`+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider`
`12`	`12`	`*`
`13`	`13`	`* @covers \BlameButton\LaravelDockerBuilder\Commands\BaseDockerCommand`
`14`	`14`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`use BlameButton\LaravelDockerBuilder\Tests\TestCase;`
`8`	`8`
`9`	`9`	`/**`
`10`		`- * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider::boot()`
	`10`	`+ * @uses \BlameButton\LaravelDockerBuilder\DockerServiceProvider`
`11`	`11`	`*`
`12`	`12`	`* @covers \BlameButton\LaravelDockerBuilder\Commands\GenerateQuestions\AlpineQuestion`
`13`	`13`	`*/`