Add test for GitHub API error

Author: bram-pkg

src/Integrations/SupportedPhpExtensions.php

@@ -14,18 +14,18 @@ public function get(string $phpVersion = null): array
             return $this->cache;
         }
 
-        try {
-            $contents = $this->fetch();
-
-            return $this->cache = collect($contents)
-                ->filter(fn (string $extension): bool => is_null($phpVersion) || str($extension)->contains($phpVersion))
-                ->map(fn (string $extension): string => str($extension)->trim()->before(' '))
-                ->filter()
-                ->values()
-                ->toArray();
-        } catch (\ErrorException) {
+        $contents = $this->fetch();
+
+        if ($contents === false) {
             return [];
         }
+
+        return $this->cache = collect($contents)
+            ->filter(fn (string $extension): bool => is_null($phpVersion) || str($extension)->contains($phpVersion))
+            ->map(fn (string $extension): string => str($extension)->trim()->before(' '))
+            ->filter()
+            ->values()
+            ->toArray();
     }
 
     protected function fetch(): array|false

tests/Unit/Integrations/SupportedPhpExtensionsTest.php

@@ -13,16 +13,26 @@
  */
 class SupportedPhpExtensionsTest extends TestCase
 {
-    protected function setUp(): void
+    public function providePhpVersions(): array
     {
-        parent::setUp();
+        return [
+            [['apcu', 'pdo_mysql'], '8.2'],
+            [['apcu', 'pdo_pgsql', 'redis'], '8.1'],
+            [['pdo_pgsql', 'memcached'], '8.0'],
+        ];
+    }
 
-        $this->partialMock(SupportedPhpExtensions::class, function (MockInterface $mock) {
+    /** @dataProvider providePhpVersions */
+    public function testItFiltersVersions($expected, $version): void
+    {
+        $this->mock(SupportedPhpExtensions::class, function (MockInterface $mock) use ($version) {
             $mock->shouldAllowMockingProtectedMethods();
             $mock->shouldReceive('get')
+                ->with($version)
                 ->once()
                 ->passthru();
             $mock->shouldReceive('fetch')
+                ->withNoArgs()
                 ->once()
                 ->andReturn([
                     'apcu 8.1 8.2',
@@ -32,22 +42,22 @@ protected function setUp(): void
                     'redis 8.1',
                 ]);
         });
-    }
 
-    public function providePhpVersions(): array
-    {
-        return [
-            [['apcu', 'pdo_mysql'], '8.2'],
-            [['apcu', 'pdo_pgsql', 'redis'], '8.1'],
-            [['pdo_pgsql', 'memcached'], '8.0'],
-        ];
+        $supported = app(SupportedPhpExtensions::class)->get($version);
+
+        self::assertEquals($expected, $supported);
     }
 
-    /** @dataProvider providePhpVersions */
-    public function testItFiltersVersions($expected, $version): void
+    public function testItReturnsEmptyArrayOnError(): void
     {
-        $supported = app(SupportedPhpExtensions::class)->get($version);
+        $this->mock(SupportedPhpExtensions::class, function(MockInterface $mock) {
+            $mock->shouldAllowMockingProtectedMethods();
+            $mock->shouldReceive('get')->once()->passthru();
+            $mock->shouldReceive('fetch')->once()->withNoArgs()->andReturn(false);
+        });
 
-        self::assertEquals($expected, $supported);
+        $supported = app(SupportedPhpExtensions::class)->get('8.2');
+
+        self::assertEquals([], $supported);
     }
 }