Skip to content

Commit c37e9ed

Browse files
committed
Fix rubocop - Layout/LineLength: Line is too long
1 parent 0e978fa commit c37e9ed

File tree

3 files changed

+21
-20
lines changed

3 files changed

+21
-20
lines changed

lib/ohloh_scm/svn/activity.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ def info(path = nil, revision = 'HEAD')
7878
# Because uri(with branch) may have characters(e.g. space) that break the shell command.
7979
def uri_encode(uri)
8080
# URI.encode is declared obsolete, however we couldn't find an alternative.
81-
# URI.encode('foo bar') => foo%20bar # `svn log svn://...foo%20bar` works in ruby 2.x
8281
# CGI.escape('foo bar') => foo+bar # `svn log svn://...foo+bar` won't work.
83-
# URI::DEFAULT_PARSER.escape('foo bar') => foo%20bar # `svn log svn://...foo%20bar` works in ruby 3.x
82+
# URI.encode('foo bar') => foo%20bar # `svn log svn://...foo%20bar` works in ruby 2.x
83+
# URI::DEFAULT_PARSER.escape('foo bar') => foo%20bar # This works in ruby 3.x
8484
URI::DEFAULT_PARSER.escape(uri)
8585
end
8686

spec/ohloh_scm/git/activity_spec.rb

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
with_git_repository('git') do |git|
5151
assert_equal git.activity.tags,
5252
[['v1.0.0', 'b6e9220c3cabe53a4ed7f32952aeaeb8a822603d', Time.parse('2016-07-31T07:58:30+05:30')],
53-
['v1.1.0-lw', '2e9366dd7a786fdb35f211fff1c8ea05c51968b1', Time.parse('2006-06-11T11:34:17-07:00')],
53+
['v1.1.0-lw', '2e9366dd7a786fdb35f211fff1c8ea05c51968b1',
54+
Time.parse('2006-06-11T11:34:17-07:00')],
5455
['v2.1.0', '1df547800dcd168e589bb9b26b4039bff3a7f7e4', Time.parse('2006-07-14T16:07:15-07:00')]]
5556
end
5657
end
@@ -165,15 +166,15 @@
165166

166167
it 'commit tokens for trunk commits' do
167168
with_git_repository('git_dupe_delete') do |git|
168-
assert_equal git.activity.commit_tokens(trunk_only: false), ['a0a2b8623941562031a7d7f95d984feb4a2d719c',
169-
'ad6bb43112706c462e53a9a8a8cd3b05f8e9260f',
170-
'6126337d2497806528fd8657181d5d4afadd72a4', # On branch
171-
'41c4b1044ebffc968d363e5f5e883134e624f846']
169+
assert_equal git.activity.commit_tokens(trunk_only: false),
170+
['a0a2b8623941562031a7d7f95d984feb4a2d719c', 'ad6bb43112706c462e53a9a8a8cd3b05f8e9260f',
171+
'6126337d2497806528fd8657181d5d4afadd72a4', # On branch
172+
'41c4b1044ebffc968d363e5f5e883134e624f846']
172173

173-
assert_equal git.activity.commit_tokens(trunk_only: true), ['a0a2b8623941562031a7d7f95d984feb4a2d719c',
174-
'ad6bb43112706c462e53a9a8a8cd3b05f8e9260f',
175-
# '6126337d2497806528fd8657181d5d4afadd72a4' # On branch
176-
'41c4b1044ebffc968d363e5f5e883134e624f846']
174+
assert_equal git.activity.commit_tokens(trunk_only: true),
175+
['a0a2b8623941562031a7d7f95d984feb4a2d719c', 'ad6bb43112706c462e53a9a8a8cd3b05f8e9260f',
176+
# '6126337d2497806528fd8657181d5d4afadd72a4' # On branch
177+
'41c4b1044ebffc968d363e5f5e883134e624f846']
177178
end
178179
end
179180

@@ -206,11 +207,11 @@
206207

207208
it 'trunk only commits' do
208209
with_git_repository('git_dupe_delete') do |git|
209-
assert_equal git.activity.commits(trunk_only: true).collect(&:token), ['a0a2b8623941562031a7d7f95d984feb4a2d719c',
210-
'ad6bb43112706c462e53a9a8a8cd3b05f8e9260f',
211-
# on a branch, hence excluded.
212-
# '6126337d2497806528fd8657181d5d4afadd72a4',
213-
'41c4b1044ebffc968d363e5f5e883134e624f846']
210+
assert_equal git.activity.commits(trunk_only: true).collect(&:token),
211+
['a0a2b8623941562031a7d7f95d984feb4a2d719c', 'ad6bb43112706c462e53a9a8a8cd3b05f8e9260f',
212+
# on a branch, hence excluded.
213+
# '6126337d2497806528fd8657181d5d4afadd72a4',
214+
'41c4b1044ebffc968d363e5f5e883134e624f846']
214215
end
215216
end
216217

spec/ohloh_scm/hg/activity_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -215,10 +215,10 @@
215215
525de321d8085bc1d4a3c7608fda6b4020027985
216216
72fe74d643bdcb30b00da3b58796c50f221017d0]
217217

218-
assert_equal hg.activity.commit_tokens(trunk_only: true), ['73e93f57224e3fd828cf014644db8eec5013cd6b',
219-
'732345b1d5f4076498132fd4b965b1fec0108a50',
220-
# '525de321d8085bc1d4a3c7608fda6b4020027985', # branch
221-
'72fe74d643bdcb30b00da3b58796c50f221017d0']
218+
assert_equal hg.activity.commit_tokens(trunk_only: true),
219+
['73e93f57224e3fd828cf014644db8eec5013cd6b', '732345b1d5f4076498132fd4b965b1fec0108a50',
220+
# '525de321d8085bc1d4a3c7608fda6b4020027985', # branch
221+
'72fe74d643bdcb30b00da3b58796c50f221017d0']
222222
end
223223
end
224224

0 commit comments

Comments
 (0)