OTWO-204 Allow spaces in Subversion file paths

Author: Robin Luckey

lib/scm/adapters/svn/validation.rb

@@ -1,11 +1,11 @@
 module Scm::Adapters
 	class SvnAdapter < AbstractAdapter
 		def self.url_regex
-			/^(file|http|https|svn):\/\/(\/)?[A-Za-z0-9_\-\.]+(:\d+)?(\/[A-Za-z0-9_\-\.\/\+%^~]*)?$/
+			/^(file|http|https|svn):\/\/(\/)?[A-Za-z0-9_\-\.]+(:\d+)?(\/[A-Za-z0-9_\-\.\/\+%^~ ]*)?$/
 		end
 
 		def self.public_url_regex
-			/^(http|https|svn):\/\/[A-Za-z0-9_\-\.]+(:\d+)?(\/[A-Za-z0-9_\-\.\/\+%^~]*)?$/
+			/^(http|https|svn):\/\/[A-Za-z0-9_\-\.]+(:\d+)?(\/[A-Za-z0-9_\-\.\/\+%^~ ]*)?$/
 		end
 
 		def normalize

test/unit/svn_validation_test.rb

@@ -12,7 +12,6 @@ def test_rejected_urls
 			[	nil, "", "foo", "http:/", "http:://", "http://",
 			"sourceforge.net/svn/project/trunk", # missing a protocol prefix
 			"http://robin@svn.sourceforge.net/", # must not include a username with the url
-			"http://svn.sourceforge.net/asdf/asdf/ malicious code", # no spaces allowed
 			"/home/robin/cvs", # local file paths not allowed
 			"git://kernel.org/whatever/linux.git", # git protocol is not allowed
 			":pserver:anonymous:@juicereceiver.cvs.sourceforge.net:/cvsroot/juicereceiver", # pserver is just wrong
@@ -38,7 +37,8 @@ def test_accepted_urls
 			"http://svn.gnome.org/svn/gtk+/trunk", # + character OK
 			"http://svn.gnome.org", # no path, no trailing /, just a domain name is OK
 			"http://brlcad.svn.sourceforge.net/svnroot/brlcad/rt^3/trunk", # a caret ^ is allowed
-			"http://www.thus.ch/~patrick/svn/pvalsecc" # ~ is allowed
+			"http://www.thus.ch/~patrick/svn/pvalsecc", # ~ is allowed
+			"http://franklinmath.googlecode.com/svn/trunk/Franklin Math", # space is allowed in path
 			].each do |url|
 				# Accepted for both internal and public use
 				[true, false].each do |p|