Merge pull request #24 from santhanakarthikeyan/replace_open3_with_posix_spawn

Replaced Open3 with Posix-spawn to reduce process memory leak

Author: santhanakarthikeyan

.install_dependencies.sh

@@ -0,0 +1,13 @@
+#/usr/bin/env sh
+
+bazaar_plugins_path=`bzr --version |  awk '/bzrlib:/ {print $2}'`
+
+cd "$bazaar_plugins_path/plugins"
+
+sudo bzr branch lp:bzr-xmloutput
+
+sudo mv bzr-xmloutput xmloutput
+
+cd xmloutput
+
+python setup.py build_ext -i

.ruby-version

@@ -0,0 +1 @@
+2.0.0

.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+install:
+  - gem install posix-spawn
+  - sh .install_dependencies.sh

README.md

@@ -49,10 +49,17 @@ hg 1.1.2
 If you are using CVS instead of CVSNT, you can potentially try creating
 a shell alias or symlink mapping 'cvsnt' to 'cvs'.
 
+Ohloh SCM uses [posix-spawn](https://github.com/rtomayko/posix-spawn) to
+execute commands so ensure *posix-spawn* gem is installed
+
+``gem install posix-spawn``
+
+
 ## Usage with Bundler
 
 ```
 gem 'ohloh_scm', git: 'https://github.com/blackducksw/ohloh_scm/', require: 'scm'
+gem 'posix-spawn'
 ```
 ## Running
 

lib/ohloh_scm/adapters/bzrlib/bzrlib_pipe_client.rb

@@ -1,5 +1,5 @@
 require 'rubygems'
-require 'open4'
+require 'posix/spawn'
 
 class BzrPipeClient
   def initialize(repository_url)
@@ -8,7 +8,7 @@ def initialize(repository_url)
   end
 
   def start
-    @pid, @stdin, @stdout, @stderr = Open4::popen4 "python #{@py_script}"
+    @pid, @stdin, @stdout, @stderr = POSIX::Spawn::popen4 "python #{@py_script}"
     open_repository
   end
 

lib/ohloh_scm/adapters/hglib/client.rb

@@ -1,5 +1,5 @@
 require 'rubygems'
-require 'open4'
+require 'posix/spawn'
 
 class HglibClient
   def initialize(repository_url)
@@ -8,7 +8,7 @@ def initialize(repository_url)
   end
 
   def start
-    @pid, @stdin, @stdout, @stderr = Open4::popen4 "python #{@py_script}"
+    @pid, @stdin, @stdout, @stderr = POSIX::Spawn::popen4 "python #{@py_script}"
     open_repository
   end
 

lib/ohloh_scm/shellout.rb

@@ -1,6 +1,6 @@
 require 'rubygems'
 require 'stringio'
-require 'open3'
+require 'posix/spawn'
 
 class Shellout
 
@@ -9,9 +9,9 @@ def self.relay src, dst
   end 
 
   def self.execute(cmd)
-    out, err, exit_status = Open3.capture3(cmd)
+    posix_spawn = POSIX::Spawn::Child.new(cmd)
 
-    return exit_status, out, err
+    return posix_spawn.status, posix_spawn.out, posix_spawn.err
   end
 
   def run(cmd)

ohloh_scm.gemspec

@@ -16,4 +16,6 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = %w(lib)
+
+  gem.add_runtime_dependency 'posix-spawn', '~> 0.3'
 end