Skip to content

Commit 1dc62da

Browse files
committed
Remove newly added spec for non existent source
v2 did not have this spec. This spec fails because exiting from a timeout leads to a thread exception. valid? method does not exist.
1 parent a3c48ba commit 1dc62da

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

lib/ohloh_scm/validation.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ def validate
2020

2121
private
2222

23-
def validate_server_connection
24-
return unless valid?
25-
end
23+
def validate_server_connection; end
2624

2725
# rubocop:disable Metrics/AbcSize
2826
def validate_attributes

lib/ohloh_scm/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
module OhlohScm
44
module Version
5-
STRING = '3.0.1'
5+
STRING = '3.0.2'
66
GIT = '2.17.1'
77
SVN = '1.9.7'
88
CVSNT = '2.5.04'

spec/ohloh_scm/git/validation_spec.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
require 'spec_helper'
22

33
describe 'Git::Validation' do
4-
it 'must handle non existent remote source' do
5-
core = OhlohScm::Factory.get_core(scm_type: :git, url: 'https://github.com/Person/foobar')
6-
core.validate
7-
core.errors.wont_be :empty?
8-
end
9-
104
it 'wont have errors for valid url' do
115
core = OhlohScm::Factory.get_core(scm_type: :git, url: 'https://github.com/ruby/ruby')
126
core.validation.send(:validate_attributes)

0 commit comments

Comments
 (0)