rubocop fix which in on CI

Author: Niharika1117

db/migrate/20170616152705_set_codelocation_status_to_zero.rb

@@ -37,7 +37,7 @@ def setup_temp_table
   end
 
   def load_temp_table_data
-    puts '  loading temp table..'
+    Datadogreport.info '  loading temp table..'
     @conn.execute("CREATE temp table kbLocations
         (id integer);")
 
@@ -53,7 +53,7 @@ def load_temp_table_data
   end
 
   def index_temp_table
-    puts '    indexing temp table....'
+    Datadogreport.info '    indexing temp table....'
     @conn.execute('CREATE INDEX ON kbLocations (id)')
   end
 
@@ -66,11 +66,11 @@ def get_possible_selection
                         NOT EXISTS
                         (SELECT id FROM kbLocations kb WHERE kb.id = cl.id);")
     message = "   updating #{code_location_count} code location records"
-    puts message
+    Datadogreport.info message
   end
 
   def update_code_location_status
-    print '      updating code location status.....'
+    Datadogreport.info '      updating code location status.....'
     get_possible_selection
     @conn.execute("UPDATE Code_Locations cl SET status = #{CodeLocation::STATUS_UNDEFINED}
       WHERE status !=  #{CodeLocation::STATUS_DELETED} AND
@@ -79,7 +79,7 @@ def update_code_location_status
   end
 
   def rollback_code_location_status
-    print '      rolling back code location status.....'
+    Datadogreport.info '      rolling back code location status.....'
     get_possible_selection
     @conn.execute("UPDATE Code_Locations cl SET status = #{CodeLocation::STATUS_ACTIVE}
       WHERE status = #{CodeLocation::STATUS_UNDEFINED} AND
@@ -88,8 +88,8 @@ def rollback_code_location_status
   end
 
   def drop_temp_table
-    puts '    dropping temp table.......'
+    Datadogreport.info '    dropping temp table.......'
     @conn.execute('DROP table kbLocations;')
-    puts 'completed'
+    Datadogreport.info 'completed'
   end
 end

lib/tasks/cleanup_nginx_logs.rake

@@ -4,5 +4,7 @@ desc 'Cleanup nginx logs'
 task cleanup_nginx_logs: :environment do
   log_file = '/var/log/nginx/openhub-access.log'
 
+  # rubocop:disable Lint/EmptyBlock
   File.open(log_file, 'w') {} if File.exist?(log_file)
+  # rubocop:enable Lint/EmptyBlock
 end

script/add_apache_github_code_locations.rb

@@ -49,7 +49,7 @@ def create_code_location(url)
     hsh = JSON.parse(response.body)
     hsh['code_location_id']
   rescue StandardError => e
-    puts e.message
+    Datadogreport.error e.message
   end
 
   def git_branch(url)

script/create_sbom_jobs_for_projects.rb

@@ -21,7 +21,7 @@ def perform(limit)
                         project_id: project.id, priority: PRIORITY)
       end
 
-      puts "Created SbomJobs for the project => #{project.id}: #{project.vanity_url}"
+      Datadogreport.info "Created SbomJobs for the project => #{project.id}: #{project.vanity_url}"
     end
   end
 

script/create_scan_project_in_ui.rb

@@ -57,7 +57,7 @@ def handle_response(project_id, row)
   end
 
   def create_code_location_scan(project_id, row)
-    puts "Project Value #{project_id} row value #{row['name']}"
+    Datadogreport.info "Project Value #{project_id} row value #{row['name']}"
 
     code_location_id = Enlistment.not_deleted.where(project_id: project_id,
                                                     code_location_id: @code_location_ids).first&.code_location_id
@@ -113,7 +113,7 @@ def get_result(uri, params)
     response = Net::HTTP.post_form(uri, params)
     [JSON.parse(response.body), response.code]
   rescue StandardError => e
-    puts e.message
+    Datadogreport.error e.message
     nil
   end
 end

script/delete_google_code_projects.rb

@@ -13,17 +13,18 @@ def initialize
   end
 
   def execute
-    puts 'starting script'
+    Datadogreport.info 'starting script'
     @project_ids = fetch_googlecode_projects_array
-    puts "Attempting to delete #{@project_ids.length} google code projects"
+    Datadogreport.info "Attempting to delete #{@project_ids.length} google code projects"
 
     # update project deleted field for all googlecode projects in batches of 1000
     until (projects = Project.find(@project_ids.slice!(0..999))).empty?
       projects.each do |project|
         undo_project(project)
       end
     end
-    puts 'Successfully completed script - Please check deleted_googlecode_log_file.log to view any exceptions'
+    Datadogreport.info 'Successfully completed script - ' \
+                       'Please check deleted_googlecode_log_file.log to view any exceptions'
   end
 
   def fetch_googlecode_projects_array
@@ -39,7 +40,7 @@ def fetch_googlecode_projects_array
   end
 
   def undo_project(project)
-    puts "Processing project #{project.id}"
+    Datadogreport.info "Processing project #{project.id}"
     begin
       project.tags.delete_all
       project.create_edit.undo!(@editor) if project.create_edit.allow_undo?

script/insert_kb_projects.rb

@@ -24,8 +24,8 @@ def run
 
   def show_progress(index)
     @log.info "Processing row #{index}"
-    print '.' unless (index % 10).zero?
-    puts index if (index % 10).zero?
+    Datadogreport.info '.' unless (index % 10).zero?
+    Datadogreport.info index if (index % 10).zero?
   end
 
   def create_project(row)
@@ -52,14 +52,15 @@ def id
 end
 
 def check_params
-  return unless ARGV.empty?
+  return true unless ARGV.empty?
 
-  puts 'Missing csv location and file name eg. tmp/test.csv'
-  exit 0
+  Datadogreport.info 'Missing csv location and file name eg. tmp/test.csv'
+  false
 end
 
-puts 'starting script'
-check_params
-file_name = ARGV[0]
-InsertKbProjects.new(file_name).run
-puts 'script complete'
+Datadogreport.info 'starting script'
+if check_params
+  file_name = ARGV[0]
+  InsertKbProjects.new(file_name).run
+  Datadogreport.info 'script complete'
+end

script/populate_travis_badge.rb

@@ -34,8 +34,8 @@ def populate
   end
 
   def print_stat
-    puts "repo_with_travis_badge: #{@repo_with_travis_badge}"
-    puts "total_badges_created:  #{@total_badges_created}"
+    Datadogreport.info "repo_with_travis_badge: #{@repo_with_travis_badge}"
+    Datadogreport.info "total_badges_created:  #{@total_badges_created}"
   end
 
   def ensure_proper_url_format(code_location)
@@ -65,7 +65,7 @@ def create_travis_badge(repo, badge_url)
       next if enlistment.travis_badges.count.positive?
       next unless enlistment.travis_badges.create(identifier: manipulated_url)
 
-      puts "Succefully created badge: #{@total_badges_created += 1}"
+      Datadogreport.info "Succefully created badge: #{@total_badges_created += 1}"
     end
   end
 

script/update_deleted_enlistments_for_deleted_projects.rb

@@ -13,18 +13,19 @@ def initialize
   end
 
   def execute
-    puts 'starting script'
+    Datadogreport.info 'starting script'
     # update enlistments deleted field for all deleted projects
     Project.where(deleted: true).find_in_batches do |projects|
       projects.each do |project|
         update_project_enlistments(project)
       end
     end
-    puts 'Successfully completed script - Please check update_deleted_enlistments_log_file.log to view any exceptions'
+    Datadogreport.info 'Successfully completed script - ' \
+                       'Please check update_deleted_enlistments_log_file.log to view any exceptions'
   end
 
   def update_project_enlistments(project)
-    puts "Processing project #{project.id}"
+    Datadogreport.info "Processing project #{project.id}"
     begin
       project.enlistments.each do |enlistment|
         enlistment.create_edit.undo!(@editor) if enlistment.create_edit.allow_undo?

script/validate_git_repositories.rb

@@ -9,7 +9,7 @@
             .where(projects: { deleted: false })
             .where(repositories: { type: 'GitRepository' })
             .find_each do |cl|
-  puts "#{cl.id} :: #{index += 1}"
+  Datadogreport.info "#{cl.id} :: #{index += 1}"
   cl.enlistments do |e|
     e.create_edit.undo!(Account.hamster) unless cl.valid?
   rescue StandardError