Skip to content

Commit 3cad5d6

Browse files
author
Shane Wright
committed
Add more graceful HTTP response checks
1 parent 2af0408 commit 3cad5d6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

examples/client/parse_spdx.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ def upload_sbom_file(filename, project, version):
341341
if response.status_code == 409:
342342
logging.error(f"File {filename} is already mapped to a different project version")
343343

344-
if response.status_code != 201:
344+
if not response.ok:
345345
logging.error(f"Failed to upload SPDX file")
346346
try:
347347
pprint(response.json()['errorMessage'])
@@ -482,7 +482,7 @@ def create_cust_comp(name, version, license):
482482
}
483483
response = bd.session.post("api/components", json=data)
484484
logging.debug(response)
485-
if response.status_code != 201:
485+
if not response.ok:
486486
# Shouldn't be possible. We checked for existence earlier.
487487
logging.error(response.json()['errors'][0]['errorMessage'])
488488
logging.error(f"Status code: {response.status_code}")
@@ -516,7 +516,7 @@ def create_cust_comp_ver(comp_url, version, license):
516516
logging.error(f"Version {version} already exists for component")
517517
sys.exit(1)
518518

519-
if response.status_code != 201:
519+
if not response.ok:
520520
logging.error(f"Failed to add Version {version} to component")
521521
sys.exit(1)
522522

@@ -532,7 +532,7 @@ def add_to_sbom(proj_version_url, comp_ver_url):
532532
'component': comp_ver_url
533533
}
534534
response = bd.session.post(proj_version_url + "/components", json=data)
535-
if (response.status_code != 200):
535+
if not response.ok:
536536
logging.error(response.json()['errors'][0]['errorMessage'])
537537
logging.error(f"Status code: {response.status_code}")
538538
sys.exit(1)

0 commit comments

Comments
 (0)