[BRE-831] Removing backward compatibility for SPs (#420)

Author: pixman20

.github/workflows/test-report-deployment-status-to-slack.yml

@@ -145,121 +145,3 @@ jobs:
           AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
           AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
           AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
-
-  test-report-start-backwards-compatibility:
-    name: Test Slack report (Backwards Compatibility)
-    runs-on: ubuntu-22.04
-    permissions:
-      contents: read
-    steps:
-      - name: Checkout
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-
-      - name: Start
-        uses: ./report-deployment-status-to-slack
-        with:
-          project: $TEST_REPORT_PROJECT
-          environment: EU-QA Cloud
-          slack-channel: bre-alerts-test
-          tag: test-workflow-start
-          event: 'start'
-          commit-sha: $TEST_REPORT_COMMIT_SHA
-          url: https://github.com/bitwarden/gh-actions/actions/runs/${{ github.run_id }}
-          AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
-      - name: Success
-        uses: ./report-deployment-status-to-slack
-        with:
-          project: $TEST_REPORT_PROJECT
-          environment: US-QA Cloud
-          slack-channel: bre-alerts-test
-          tag: test-workflow-success
-          event: 'success'
-          commit-sha: $TEST_REPORT_COMMIT_SHA
-          url: https://github.com/bitwarden/gh-actions/actions/runs/${{ github.run_id }}
-          AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
-      - name: Failure
-        uses: ./report-deployment-status-to-slack
-        with:
-          project: $TEST_REPORT_PROJECT
-          environment: US-QA Cloud
-          slack-channel: bre-alerts-test
-          tag: test-workflow-failure
-          event: 'failure'
-          commit-sha: $TEST_REPORT_COMMIT_SHA
-          url: https://github.com/bitwarden/gh-actions/actions/runs/${{ github.run_id }}
-          AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
-      - name: No Changes
-        uses: ./report-deployment-status-to-slack
-        with:
-          project: $TEST_REPORT_PROJECT
-          environment: EU-QA Cloud
-          slack-channel: bre-alerts-test
-          tag: test-workflow-failure
-          event: 'no-changes'
-          commit-sha: $TEST_REPORT_COMMIT_SHA
-          url: https://github.com/bitwarden/gh-actions/actions/runs/${{ github.run_id }}
-          AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
-  test-report-db-migration-backwards-compatibility:
-    name: Test Slack report with different DB migration scenerios (Backwards Compatibility)
-    runs-on: ubuntu-22.04
-    permissions:
-      contents: read
-    steps:
-      - name: Checkout
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-
-      - name: With DB migration true on main
-        uses: ./report-deployment-status-to-slack
-        with:
-          project: $TEST_REPORT_PROJECT
-          environment: EU-QA Cloud
-          slack-channel: bre-alerts-test
-          tag: main
-          event: 'success'
-          commit-sha: $TEST_REPORT_COMMIT_SHA
-          db_migration_detected: true
-          url: https://github.com/bitwarden/gh-actions/actions/runs/${{ github.run_id }}
-          AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
-      - name: With DB migration false on main
-        uses: ./report-deployment-status-to-slack
-        with:
-          project: $TEST_REPORT_PROJECT
-          environment: US-QA Cloud
-          slack-channel: bre-alerts-test
-          tag: main
-          event: 'failure'
-          commit-sha: $TEST_REPORT_COMMIT_SHA
-          db_migration_detected: false
-          url: https://github.com/bitwarden/gh-actions/actions/runs/${{ github.run_id }}
-          AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
-      - name: With DB migration true on test branch
-        uses: ./report-deployment-status-to-slack
-        with:
-          project: $TEST_REPORT_PROJECT
-          environment: EU-QA Cloud
-          slack-channel: bre-alerts-test
-          tag: test-branch-failure
-          event: 'failure'
-          commit-sha: $TEST_REPORT_COMMIT_SHA
-          db_migration_detected: false
-          url: https://github.com/bitwarden/gh-actions/actions/runs/${{ github.run_id }}
-          AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
-      - name: With DB migration false on test branch
-        uses: ./report-deployment-status-to-slack
-        with:
-          project: $TEST_REPORT_PROJECT
-          environment: US-QA Cloud
-          slack-channel: bre-alerts-test
-          tag: test-branch-success
-          event: 'success'
-          commit-sha: $TEST_REPORT_COMMIT_SHA
-          db_migration_detected: true
-          url: https://github.com/bitwarden/gh-actions/actions/runs/${{ github.run_id }}
-          AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}

.github/workflows/test-report-upcoming-release-version.yml

@@ -6,24 +6,6 @@ on:
       - ".github/workflows/test-report-upcoming-release-version.yml"
 
 jobs:
-  # Remove this step after all repositories are switched over to OIDC, but currently test for backwards compatibility
-  test-report-upcoming-release-version-backward-compatibility:
-    name: Test report upcoming release version to Slack (Backwards Compatibility)
-    runs-on: ubuntu-22.04
-    permissions:
-      contents: read
-    steps:
-      - name: Checkout
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-
-      - name: Report upcoming release version to Slack
-        uses: ./report-upcoming-release-version
-        with:
-          project: bitwarden/server
-          version: upcoming_version_1
-          slack-channel: bre-alerts-test
-          AZURE_KV_CI_SERVICE_PRINCIPAL: ${{ secrets.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
   test-report-upcoming-release-version-oidc:
     name: Test report upcoming release version to Slack
     runs-on: ubuntu-22.04

report-deployment-status-to-slack/action.yml

@@ -34,22 +34,15 @@ inputs:
     description: "URL of the deployment action run"
     required: false
     default: ${{ github.event.deployment_status.target_url }}
-  AZURE_KV_CI_SERVICE_PRINCIPAL:
-    description: "The service principal used to authenticate to Azure. (Deprecated, use AZURE ID inputs instead)"
-    required: false
-    default: ""
   AZURE_SUBSCRIPTION_ID:
     description: "Azure Subscription ID for the service principal."
-    required: false
-    default: ""
+    required: true
   AZURE_TENANT_ID:
     description: "Azure Tenant ID for the service principal."
-    required: false
-    default: ""
+    required: true
   AZURE_CLIENT_ID:
     description: "Azure Client ID for the service principal."
-    required: false
-    default: ""
+    required: true
 outputs:
   channel_id:
     description: "Channel ID where the Slack message was posted"
@@ -61,21 +54,7 @@ outputs:
 runs:
   using: "composite"
   steps:
-    - name: Missing inputs check
-      if: ${{ inputs.AZURE_KV_CI_SERVICE_PRINCIPAL == '' && inputs.AZURE_CLIENT_ID == '' }}
-      shell: bash
-      run: |
-        echo "Error: Either AZURE_KV_CI_SERVICE_PRINCIPAL or AZURE_CLIENT_ID input must be provided."
-        exit 1
-
-    - name: Login to Azure - Prod Subscription
-      if: ${{ inputs.AZURE_KV_CI_SERVICE_PRINCIPAL != '' }}
-      uses: Azure/login@e15b166166a8746d1a47596803bd8c1b595455cf # v1.6.0
-      with:
-        creds: ${{ inputs.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
     - name: Azure Login
-      if: ${{ inputs.AZURE_CLIENT_ID != '' }}
       uses: bitwarden/gh-actions/azure-login@main
       with:
         subscription_id: ${{ inputs.AZURE_SUBSCRIPTION_ID }}

report-upcoming-release-version/action.yml

@@ -10,22 +10,15 @@ inputs:
   slack-channel:
     description: "The name of the Slack channel."
     default: release
-  AZURE_KV_CI_SERVICE_PRINCIPAL:
-    description: "The service principal used to authenticate to Azure. (Deprecated, use AZURE ID inputs instead)"
-    required: false
-    default: ""
   AZURE_SUBSCRIPTION_ID:
     description: "Azure Subscription ID for the service principal."
-    required: false
-    default: ""
+    required: true
   AZURE_TENANT_ID:
     description: "Azure Tenant ID for the service principal."
-    required: false
-    default: ""
+    required: true
   AZURE_CLIENT_ID:
     description: "Azure Client ID for the service principal."
-    required: false
-    default: ""
+    required: true
 outputs:
   channel_id:
     description: "Channel ID where the Slack message was posted."
@@ -34,21 +27,7 @@ outputs:
 runs:
   using: "composite"
   steps:
-    - name: Missing inputs check
-      if: ${{ inputs.AZURE_KV_CI_SERVICE_PRINCIPAL == '' && inputs.AZURE_CLIENT_ID == '' }}
-      shell: bash
-      run: |
-        echo "Error: Either AZURE_KV_CI_SERVICE_PRINCIPAL or AZURE_CLIENT_ID input must be provided."
-        exit 1
-
-    - name: Login to Azure - Prod Subscription
-      if: ${{ inputs.AZURE_KV_CI_SERVICE_PRINCIPAL != '' }}
-      uses: Azure/login@e15b166166a8746d1a47596803bd8c1b595455cf # v1.6.0
-      with:
-        creds: ${{ inputs.AZURE_KV_CI_SERVICE_PRINCIPAL }}
-
     - name: Azure Login
-      if: ${{ inputs.AZURE_CLIENT_ID != '' }}
       uses: bitwarden/gh-actions/azure-login@main
       with:
         subscription_id: ${{ inputs.AZURE_SUBSCRIPTION_ID }}