Propagate error also in the reader, not just in waiting threads

Author: RCasatta

src/client.rs

@@ -111,7 +111,7 @@ impl ClientType {
 }
 
 impl Client {
-    /// Default constructor supporting multiple backend by providing a prefix
+    /// Default constructor supporting multiple backends by providing a prefix
     ///
     /// Supported prefixes are:
     /// - tcp:// for a TCP plaintext client.

src/raw_client.rs

@@ -404,6 +404,7 @@ impl<S: Read + Write> RawClient<S> {
                             s.send(ChannelMessage::Error(error.clone()))
                                 .expect("Unable to send ChannelMessage::Error");
                         }
+                        return Err(Error::SharedIOError(error.clone()));
                     }
                     trace!("<== {}", raw_resp);
 
@@ -535,7 +536,7 @@ impl<S: Read + Write> RawClient<S> {
                         Ok(ChannelMessage::Error(e)) => {
                             warn!("Received ChannelMessage::Error");
 
-                            break Err(Error::ChannelError(e));
+                            break Err(Error::SharedIOError(e));
                         }
                         e @ Err(_) => e.map(|_| ()).expect("Error receiving from channel"), // panic if there's something wrong with the channels
                     }

src/types.rs

@@ -291,8 +291,8 @@ pub enum Error {
     SSLOverSocks5,
     /// Made one or multiple attempts, always in Error
     AllAttemptsErrored(Vec<Error>),
-    /// There was an error transmitted from the reader thread to others
-    ChannelError(Arc<std::io::Error>),
+    /// There was an io error reading the socket, to be shared between threads
+    SharedIOError(Arc<std::io::Error>),
     /// Setting both a proxy and a timeout in `Config` results in this error
     BothSocksAndTimeout,
     /// Setting both a timeout and passing zero or more than one socket addrs is an error