Skip to content

Commit 7b12f35

Browse files
committed
Merge #747: Run code coverage on every PR
aa0ea6a codecov: warn about missing features (Daniela Brozzoni) c3a7bbb codecov: slightly change the test features (Daniela Brozzoni) 1c4d478 Run code coverage on every PR (Daniela Brozzoni) Pull request description: ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: notmandatory: ACK aa0ea6a afilini: ACK aa0ea6a Tree-SHA512: c2d0d9ad1e956f1c1808b46394f810939154442534241f9a023f18173910339ac236a5b6c66f78207dd2cb90a8f18000fc057b960e3354e2882c627fe1ef2c9f
2 parents 06310f1 + aa0ea6a commit 7b12f35

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

.github/workflows/code_coverage.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
on: [push]
1+
on: [push, pull_request]
22

33
name: Code Coverage
44

@@ -38,7 +38,13 @@ jobs:
3838
- name: Install grcov
3939
run: if [[ ! -e ~/.cargo/bin/grcov ]]; then cargo install grcov; fi
4040
- name: Test
41-
run: cargo test --features default,minimal,all-keys,compact_filters,key-value-db,compiler,sqlite,sqlite-bundled,test-electrum,verify,test-rpc
41+
# WARNING: this is not testing the following features: test-esplora, test-hardware-signer, async-interface
42+
# This is because some of our features are mutually exclusive, and generating various reports and
43+
# merging them doesn't seem to be working very well.
44+
# For more info, see:
45+
# - https://github.com/bitcoindevkit/bdk/issues/696
46+
# - https://github.com/bitcoindevkit/bdk/pull/748#issuecomment-1242721040
47+
run: cargo test --features all-keys,compact_filters,compiler,key-value-db,sqlite,sqlite-bundled,test-electrum,test-rpc,verify
4248
- name: Run grcov
4349
run: mkdir coverage; grcov . --binary-path ./target/debug/ -s . -t lcov --branch --ignore-not-existing --ignore '/*' -o ./coverage/lcov.info
4450
- name: Generate HTML coverage report

0 commit comments

Comments
 (0)