Code review fixes

Author: rubensmachion

BDKSwiftExampleWallet/Service/BDK Service/BDKService.swift

@@ -86,9 +86,9 @@ struct BDKClient {
     let fullScanWithFullScanProgress: (@escaping FullScanProgress) async throws -> Void
     let getAddress: () throws -> String
     let send: (String, UInt64, UInt64) throws -> Void
-    let calculateFee: (BitcoinDevKit.Transaction) throws -> Amount
-    let calculateFeeRate: (BitcoinDevKit.Transaction) throws -> UInt64
-    let sentAndReceived: (BitcoinDevKit.Transaction) throws -> SentAndReceivedValues
+    let calculateFee: (Transaction) throws -> Amount
+    let calculateFeeRate: (Transaction) throws -> UInt64
+    let sentAndReceived: (Transaction) throws -> SentAndReceivedValues
     let buildTransaction: (String, UInt64, UInt64) throws -> Psbt
     let getBackupInfo: () throws -> BackupInfo
     let needsFullScan: () -> Bool

BDKSwiftExampleWallet/View Model/Activity/TransactionDetailViewModel.swift

@@ -28,7 +28,7 @@ class TransactionDetailViewModel {
         self.bdkClient = bdkClient
     }
 
-    func getCalulateFee(tx: BitcoinDevKit.Transaction) {
+    func getCalulateFee(tx: Transaction) {
         do {
             let calculateFee = try bdkClient.calculateFee(tx)
             let feeString = String(calculateFee.toSat())
@@ -61,7 +61,7 @@ class TransactionDetailViewModel {
         self.network = bdkClient.getNetwork().description
     }
 
-    func getSentAndReceived(tx: BitcoinDevKit.Transaction) -> SentAndReceivedValues? {
+    func getSentAndReceived(tx: Transaction) -> SentAndReceivedValues? {
         do {
             let sentAndReceived = try bdkClient.sentAndReceived(tx)
             return sentAndReceived

BDKSwiftExampleWallet/View Model/Activity/TransactionListViewModel.swift

@@ -22,7 +22,7 @@ class TransactionListViewModel {
         self.bdkClient = bdkClient
     }
 
-    func getSentAndReceived(tx: BitcoinDevKit.Transaction) -> SentAndReceivedValues? {
+    func getSentAndReceived(tx: Transaction) -> SentAndReceivedValues? {
         do {
             let sentAndReceived = try bdkClient.sentAndReceived(tx)
             return sentAndReceived

BDKSwiftExampleWallet/View Model/Send/BuildTransactionViewModel.swift

@@ -40,7 +40,7 @@ class BuildTransactionViewModel {
         }
     }
 
-    func extractTransaction() -> BitcoinDevKit.Transaction? {
+    func extractTransaction() -> Transaction? {
         guard let psbt = self.psbt else {
             return nil
         }
@@ -56,7 +56,7 @@ class BuildTransactionViewModel {
         }
     }
 
-    func getCalulateFee(tx: BitcoinDevKit.Transaction) {
+    func getCalulateFee(tx: Transaction) {
         do {
             let calculateFee = try bdkClient.calculateFee(tx)
             let feeString = String(calculateFee.toSat())