Skip to content

Commit c82a185

Browse files
committed
fixup! secp memcmp and spacing
1 parent 2bb0baf commit c82a185

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/hsort_impl.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,13 @@ static SECP256K1_INLINE void secp256k1_heap_down(unsigned char *arr, size_t i, s
101101
/* In-place heap sort. */
102102
static void secp256k1_hsort(void *ptr, size_t count, size_t size,
103103
int (*cmp)(const void *, const void *, void *),
104-
void *cmp_data ) {
104+
void *cmp_data) {
105105
size_t i;
106106

107-
for(i = count/2; 0 < i; --i) {
107+
for (i = count/2; 0 < i; --i) {
108108
secp256k1_heap_down(ptr, i-1, count, size, cmp, cmp_data);
109109
}
110-
for(i = count; 1 < i; --i) {
110+
for (i = count; 1 < i; --i) {
111111
/* Extract the largest value from the heap */
112112
secp256k1_heap_swap(ptr, 0, i-1, size);
113113

src/tests.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3693,7 +3693,7 @@ static void test_heap_swap(void) {
36933693
static void test_hsort_is_sorted(unsigned char *elements, size_t n, size_t len) {
36943694
size_t i;
36953695
for (i = 1; i < n; i++) {
3696-
CHECK(memcmp(&elements[(i-1) * len], &elements[i * len], len) <= 0);
3696+
CHECK(secp256k1_memcmp_var(&elements[(i-1) * len], &elements[i * len], len) <= 0);
36973697
}
36983698
}
36993699

@@ -3702,10 +3702,11 @@ struct test_hsort_cmp_data {
37023702
size_t element_len;
37033703
};
37043704

3705+
37053706
static int test_hsort_cmp(const void *ele1, const void *ele2, void *data) {
37063707
struct test_hsort_cmp_data *d = (struct test_hsort_cmp_data *) data;
3707-
d->counter += 1;
3708-
return memcmp((unsigned char *)ele1, (unsigned char *)ele2, d->element_len);
3708+
d->counter += 1;
3709+
return secp256k1_memcmp_var((unsigned char *)ele1, (unsigned char *)ele2, d->element_len);
37093710
}
37103711

37113712
#define NUM 65

0 commit comments

Comments
 (0)