cmake: Make secp256k1_objs inherit interface defines from secp256k1

hebasto · hebasto · commit bf082221ff55 · 2025-07-18T17:37:09.000+01:00
This change effectively adds `-DSECP256K1_STATIC` to usage requirements
of `secp256k1_objs` on Windows, preventing LNK4217 linker warnings.
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -86,7 +86,8 @@ target_include_directories(secp256k1 INTERFACE
   $<BUILD_INTERFACE:$<$<NOT:$<BOOL:${PROJECT_IS_TOP_LEVEL}>>:${PROJECT_SOURCE_DIR}/include>>
 )
 set_target_properties(secp256k1_objs PROPERTIES
-    INTERFACE_INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:secp256k1,INTERFACE_INCLUDE_DIRECTORIES>"
+  INTERFACE_COMPILE_DEFINITIONS "$<TARGET_PROPERTY:secp256k1,INTERFACE_COMPILE_DEFINITIONS>"
+  INTERFACE_INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:secp256k1,INTERFACE_INCLUDE_DIRECTORIES>"
 )
 
 # This emulates Libtool to make sure Libtool and CMake agree on the ABI version,

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ target_include_directories(secp256k1 INTERFACE`
`86`	`86`	`$<BUILD_INTERFACE:$<$<NOT:$<BOOL:${PROJECT_IS_TOP_LEVEL}>>:${PROJECT_SOURCE_DIR}/include>>`
`87`	`87`	`)`
`88`	`88`	`set_target_properties(secp256k1_objs PROPERTIES`
`89`		`- INTERFACE_INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:secp256k1,INTERFACE_INCLUDE_DIRECTORIES>"`
	`89`	`+ INTERFACE_COMPILE_DEFINITIONS "$<TARGET_PROPERTY:secp256k1,INTERFACE_COMPILE_DEFINITIONS>"`
	`90`	`+ INTERFACE_INCLUDE_DIRECTORIES "$<TARGET_PROPERTY:secp256k1,INTERFACE_INCLUDE_DIRECTORIES>"`
`90`	`91`	`)`
`91`	`92`
`92`	`93`	`# This emulates Libtool to make sure Libtool and CMake agree on the ABI version,`