Skip to content

Commit aa2448a

Browse files
build: Remove visibility workaround for Windows
This is no longer necessary. While ((visibility("hidden"))) will also trigger the bug, this attribute is only applied when SECP256K1_FORCE_HIDDEN_VISIBILITY is set, which is specific to ELF. This partially reverts commit 447334c.
1 parent aa9cdb8 commit aa2448a

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

include/secp256k1.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -134,15 +134,6 @@ typedef int (*secp256k1_nonce_function)(
134134
* 1. If using Libtool, it defines DLL_EXPORT automatically.
135135
* 2. In other cases, SECP256K1_DLL_EXPORT must be defined. */
136136
# define SECP256K1_API extern __declspec (dllexport)
137-
# else
138-
/* Building libsecp256k1 as a static library on Windows.
139-
* No declspec is needed, and so we would want the non-Windows-specific
140-
* logic below take care of this case. However, this may result in setting
141-
* __attribute__ ((visibility("default"))), which is supposed to be a noop
142-
* on Windows but may trigger warnings when compiling with -flto due to a
143-
* bug in GCC, see
144-
* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116478 . */
145-
# define SECP256K1_API extern
146137
# endif
147138
/* The user must define SECP256K1_STATIC when consuming libsecp256k1 as a static
148139
* library on Windows. */

0 commit comments

Comments
 (0)