Skip to content

Commit 43bb4be

Browse files
build: Remove unneeded ((visibility ("default")))
On non-Windows, we initially had `-fvisibility=hidden` to set gcc's default to "hidden" together with `((visibility ("default")))` to override it for our API exports. Then 8854805 got rid of the `-fvisibility=hidden` default by adding `((visibility ("hidden")))` to all non-static definitions that should not be exported. But this means we also won't need to set `((visibility ("default")))` anywhere. The preprocessor logic could be simplified now but we keep it because we'll need it in the following commit.
1 parent 9239447 commit 43bb4be

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/secp256k1.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ typedef int (*secp256k1_nonce_function)(
155155
/* All cases not captured by the Windows-specific logic. */
156156
# if defined(__GNUC__) && (__GNUC__ >= 4) && defined(SECP256K1_BUILD)
157157
/* Building libsecp256k1 using GCC or compatible. */
158-
# define SECP256K1_API extern __attribute__ ((visibility ("default")))
158+
# define SECP256K1_API extern
159159
# else
160160
/* Fall back to standard C's extern. */
161161
# define SECP256K1_API extern

0 commit comments

Comments
 (0)