Merge #148: util: fix -Wpessimizing-move warning

ryanofsky · ryanofsky · commit 477405eda34d · 2025-02-03T21:54:27.000-05:00
3bce9d0 util: fix -Wpessimizing-move warning (Ryan Ofsky) Pull request description: /ci_container_base/src/ipc/libmultiprocess/src/mp/util.cpp:74:12: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] 74 | return std::move(buffer.str()); | ^ /ci_container_base/src/ipc/libmultiprocess/src/mp/util.cpp:74:12: note: remove std::move call here 74 | return std::move(buffer.str()); | ^~~~~~~~~~ ~ Top commit has no ACKs. Tree-SHA512: 85bc162e435bcf21f46debee31b514115fa420fb03fb1e5b7e4924ef20e61104c765a209a324a497d8ba9f97332e5df0409dfcc494389fd1ae66c96e566d2787
diff --git a/src/mp/util.cpp b/src/mp/util.cpp
@@ -71,7 +71,7 @@ std::string ThreadName(const char* exe_name)
     buffer << std::this_thread::get_id();
 #endif
 
-    return std::move(buffer.str());
+    return std::move(buffer).str();
 }
 
 std::string LogEscape(const kj::StringTree& string)

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ std::string ThreadName(const char* exe_name)`
`71`	`71`	`buffer << std::this_thread::get_id();`
`72`	`72`	`#endif`
`73`	`73`
`74`		`- return std::move(buffer.str());`
	`74`	`+ return std::move(buffer).str();`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`std::string LogEscape(const kj::StringTree& string)`