Skip to content

Commit fe8d15c

Browse files
committed
Merge bitcoin/bitcoin#26630: test: Fix intermittent issue in rpc_net.py
fadf7b8 test: Fix intermittent issue in rpc_net.py (MarcoFalke) Pull request description: Both nodes must be aware of the closed connections before re-connecting, otherwise the test will fail. Fixes #25741 ACKs for top commit: jarolrod: ACK fadf7b8 Tree-SHA512: 0492dd59a46516007e903fe8f6288982e305d4fd152a0297dd60e10ac663efc9bdc0bc6d1d2c6ec5f239196dac08319f37b079401fe057e4864b117b0fd9dcbc
2 parents cac29f5 + fadf7b8 commit fe8d15c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/functional/rpc_net.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,8 @@ def test_getnetworkinfo(self):
185185
self.nodes[0].setnetworkactive(state=False)
186186
assert_equal(self.nodes[0].getnetworkinfo()['networkactive'], False)
187187
# Wait a bit for all sockets to close
188-
self.wait_until(lambda: self.nodes[0].getnetworkinfo()['connections'] == 0, timeout=3)
188+
for n in self.nodes:
189+
self.wait_until(lambda: n.getnetworkinfo()['connections'] == 0, timeout=3)
189190

190191
with self.nodes[0].assert_debug_log(expected_msgs=['SetNetworkActive: true\n']):
191192
self.nodes[0].setnetworkactive(state=True)

0 commit comments

Comments
 (0)