Skip to content

Commit fae3bf6

Browse files
author
MarcoFalke
committed
test: Avoid redundant stop and error spam on startup failure
Trying to immediately shut down a node after a startup failure without waiting for the RPC to be fully up will in most cases just fail and lead to an RPC error. Also, it is confusing to sidestep the existing fallback to kill any leftover nodes on a test failure. So just rely on the fallback.
1 parent fa0dc09 commit fae3bf6

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

test/functional/test_framework/test_framework.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -567,15 +567,10 @@ def start_nodes(self, extra_args=None, *args, **kwargs):
567567
if extra_args is None:
568568
extra_args = [None] * self.num_nodes
569569
assert_equal(len(extra_args), self.num_nodes)
570-
try:
571-
for i, node in enumerate(self.nodes):
572-
node.start(extra_args[i], *args, **kwargs)
573-
for node in self.nodes:
574-
node.wait_for_rpc_connection()
575-
except Exception:
576-
# If one node failed to start, stop the others
577-
self.stop_nodes()
578-
raise
570+
for i, node in enumerate(self.nodes):
571+
node.start(extra_args[i], *args, **kwargs)
572+
for node in self.nodes:
573+
node.wait_for_rpc_connection()
579574

580575
if self.options.coveragedir is not None:
581576
for node in self.nodes:

0 commit comments

Comments
 (0)